Hi! (a bit late) The repo you've mentioned is owned by David Vittor, JSPWiki committer and PMC member. IIRC, he put up that repo with his own collection of plugins and took the JDBC page provider when we removed it from the core, so it could still be available.
Given that the page provider came originally from JSPWiki itself I'd say it's okay if you want to make a PR with the provider into a separate module. cheers, juan pablo On Sun, Sep 8, 2024 at 10:35 PM Alex O'Ree <alexo...@apache.org> wrote: > > So... plugins... I have an open PR to this repo > https://github.com/digitalspider/jspwiki-plugins/ which i doubt will ever > get merged. It is ASF licensed but i wouldn't feel comfortable just coping > and pasting into an apache repo for it. Need consent from the original > authors. That said, i have no clue if it works or not. Haven't tested the > jdbc setup yet, but the PR versions of most of the plugins seem to work. > > As far as testing/unit tests for database providers, I can probably help > with this using apache derby for integration tests, or sqlite. derby is > probably a better option (although harder) as derby is strict ansi sql > whereas all other vendors have their own flavor of everything and their > specific behavior varies. > > But my largest concern right now is the authorization hook that's not > working correctly with my whacky authentication scenario and the various > user experience issues i've ran across. jspwiki is really the best option > for my use case and i'll put in the time to help improvement it if needed > > On Sun, Sep 8, 2024 at 9:46 AM Juan Pablo Santos Rodríguez < > juanpablo.san...@gmail.com> wrote: > > > Hi! > > > > Sincerely, I don't remember why we move out the db provider; probably > > something in between lack of user base, bugs, problems unit-testing it > > and / or outdated dependencies. > > > > Said that, we currently ship a module for a AWS Kendra based page > > provider, which most probably would be less used than a db based one. > > Speaking for myself, JDBC, Elastic, Mongo, JCR or Git based > > page/attachment repositories are more than welcome :-) > > > > My take on this kind of contributions would be to bring them in, as a > > separate maven module, so if we have to drop support later on becasue > > of whatever, that's easy to do. If anyone, instead of making a > > contribution to the codebase, wants to have it separately on another > > repo, that's also absolutely fine too, please do tell us! so we can > > reference it from jspwiki-wiki.a.o and (if on github) please add a > > jspwiki label to your repo so it can be easily discoverable. > > > > > > cheers, > > juan pablo > > > > On Mon, Sep 2, 2024 at 1:25 AM Murray Altheim <murra...@altheim.com> > > wrote: > > > > > > Hi Alex, > > > > > > I'd be interested in others' opinions on this, but my thought is that > > > there's little real harm in providing page adapters for popular DBs, > > > and not a lot of downside except the always-real issue of > > maintainability. > > > If we as a team lose the member that provides the feature we're then > > > in a position of supporting it. > > > > > > That said, my first two cabs off the rank would be git and Spring Data, > > > the latter is pretty flexible about its own backend, and pretty easy > > > to use. Being able to back JSPWiki with a git repository would also be > > > an interesting idea, something I've myself toyed with over the years. > > > > > > I have written a JSPWiki page adapter for my own bespoke database that > > > I use within a CLI app I wrote, where the actual stored data is a JSON > > > metadata header followed by the page data. That particular format is > > > actually the native format for the app itself, so porting it for use > > > with JSPWiki was pretty trivial. But given nobody else but me would be > > > using it I hadn't thought to contribute it, though in theory that > > > format works pretty well as a complete replacement for JSPWiki since > > > it merges metadata and data in one file. This is sorta like the early > > > Macintosh's file format with its resource and data forks... (though > > > that reference may be too ancient for many people). > > > > > > Cheers, > > > > > > Murray > > > > > > On 2/09/24 06:00, Alex O'Ree wrote: > > > > Hi i was considering writing page adapters for a few database based > > page > > > > and attachment providers. I knew there was JDBC support somewhere but i > > > > noticed it's actually not in this code base. It's actually over here > > (and > > > > it hasn't been touched in almost 10 years): > > > > > > > > https://github.com/digitalspider/jspwiki-plugins/ > > > > > > > > So my question is, is there any interest in adding a JDBC, or perhaps > > mongo > > > > or elastic search page and attachment adapter within this repo? Or is > > the > > > > preference to keep this project...more bare bones and leave the > > plugins for > > > > other repos? > > > > > > > > > > -- > > > > > > > > ........................................................................... > > > Murray Altheim <murray18 at altheim dot com> = = > > === > > > http://www.altheim.com/murray/ === > > === > > > = = > > === > > > In the evening > > > The rice leaves in the garden > > > Rustle in the autumn wind > > > That blows through my reed hut. > > > -- Minamoto no Tsunenobu > > > > >
