Hi Ulf, I remember at one point a very long time ago building a popup menu for an app that had options for a wide variety of different regex syntaxes, as there are quite a few around.
In the case of the internals of JSPWiki, I think it's well past time to drop ORO and adopt Java's regex, based on the principle of least surprise alone. As for the IfPlugin, I think that a notice on the plugin page and some kind of declaration similar to what you've just written would suffice for users, so that they could make a judgment about upgrading and potentially breaking any instances of ORO regex on their pages. This (in theory) would be relatively straightforward to determine. So yes, I think it's a great idea. Simplifies and cleans up the code base and removes an very outdated dependency. Cheers, Murray On 15/07/24 20:54, Ulf Dittmer wrote:
Hi- The ORO library is obsolete, but is still in use in JSPWiki. https://issues.apache.org/jira/browse/JSPWIKI-794 mentioned it as a possible candidate for replacement some 11 years ago. I would be interested in replacing this with java.util.regex (and submit a PR), but wanted to sound out opinion about that here. It's used in 15 classes in jspwiki-main, which seems manageable (although I haven't checked if it uses regex features that the JRE doesn't support), but in at least one case -the IfPlugin- it's used to process use-supplied parameters. So it wouldn't be a case of just migrating the main codebase, and making sure that it works, but of users potentially having to change page content. Has anyone considered this, or maybe even looked into this in the past? Ulf
-- ........................................................................... Murray Altheim <murray18 at altheim dot com> = = === http://www.altheim.com/murray/ === === = = === In the evening The rice leaves in the garden Rustle in the autumn wind That blows through my reed hut. -- Minamoto no Tsunenobu
