arturobernalg commented on PR #351: URL: https://github.com/apache/jspwiki/pull/351#issuecomment-2214677214
> Hi, > > couple of notes, > > * the test-jar issue could be solved just by placing `<skip>false</skip>`just below/inside the [pom generating the test-jar](https://github.com/apache/jspwiki/blob/master/jspwiki-210-test-adaptees/pom.xml#L93). That config defaults to `${maven.test.skip}` and that's why on a clean environment the build fails (the artifact is not built) > > * `-DskipTests` skips test execution, whereas `-Dmaven.test.skip` skips tests execution _and_ compilation, so it's a bit faster. At the deploy stage test had already passed so that flag was added to speed the deploy a bit. Unsure how applying both flags solves the issue on a clean env (no 2.12.3-SNAPSHOT on local repository and `-o` passed to the build) > > * non sonar builds are skipping tests; they shouldn't they help us ensure there are no problems with other JDKs > > * as for switching to jdk-17 > > * this would force everyone consuming the snapshot artifacts to forcibly use JDK-17. I'd rather do that at the same time of moving from javax to jakarta, preferably on another PR > * when we move to jdk-17, as the sonar scanner requires also at least jdk-17, the stage of the jenkinsfile could be simplified by undoing thie [commit](https://github.com/apache/jspwiki/commit/8c0d55e344d3f48ca7747e05fa2306a32b72800c) > > > cheers, juan pablo Hi @juanpablo-santos , Thanks for your feedback. Test-Jar Issue: I added <skip>false</skip> to the maven-jar-plugin configuration in the jspwiki-210-test-adaptee module to ensure the test-jar is always built. Test Execution: I will ensure that non-Sonar builds do not skip tests to maintain coverage and catch issues across different JDKs. JDK-17 Integration: I agree that switching to JDK-17 and moving from javax to jakarta should be handled in a separate PR to ensure a smooth transition. Once we switch to JDK-17, we can simplify the Jenkinsfile accordingly. Cheers, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
