arturobernalg commented on PR #311: URL: https://github.com/apache/jspwiki/pull/311#issuecomment-1747308089
> Hi, > > wiki installations behind an apache web server (or similar) would send their internal URL, which surely wouldn't be intended. We could also check for known headers with the "external" IP/domain, but again there're going to be corner cases. > > We used to had a wiki property for that, but we moved away from it some time/years ago.. There's a JIRA for that IIRc. > > So, I'm not really sure which would be the best way to tackle this.. Perhaps check for an specific header with the domain/IP and if not found revert to the proposed solution? That would allow moving the problem/customization to the web server configuration ([ex.](https://serverfault.com/a/716154)). Again, that would be very similar to reintroducing a wiki property so not really sure this is the best way.. > > @arturobernalg would you mind opening a thread with this at [dev@j.a.o](mailto:dev@j.a.o)? so it doesn't get clobbered up with all the GH mails > > thx! Please @juanpablo-santos do another pass. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
