Hi! made some comments on the PR, let's try to bring back the reverted config and applying your changes. If it works as expected, I see no reason to not merging it
cheers, juan pablo On Sat, Jun 10, 2023 at 11:35 PM Arturo Bernal <arturobern...@yahoo.com.invalid> wrote: > > HI Juan Pablo, > > I have been exploring possible solutions for this conflict and have proposed > a potential fix by adjusting the nested dependencies within the plugin. This > was done by suggesting the exclusion of the minimatch dependency from the > globlibrary within the wro4j-maven-plugin. > > However, please note that I cannot fully guarantee the efficacy of this > solution without complete knowledge of the wider system and its dependencies. > Exclusions can sometimes lead to runtime issues, particularly if parts of our > code are dependent on the excluded libraries. > > I have created a pull request (https://github.com/apache/jspwiki/pull/285) > with these changes and I recommend thorough testing of these modifications to > ensure it doesn't inadvertently cause other issues. > > Best regards, > > > Arturo Bernal > arturobern...@yahoo.com > > > > > On 9 May 2023, at 00:26, Juan Pablo Santos Rodríguez > > <juanpablo.san...@gmail.com> wrote: > > > > Hi, > > > > finally tonight I was able to begin with the release vote for 2.12.0 and > > prepare the RC1 artifacts. Unfortunately, I've just seen that the docker > > images aren't compiling due to an error on the main module while executing > > mvn -B dependency:go-offline (we do that in order to cache the artifacts > > download and speed up the docker build); seems that some transitive > > dependencies on the wro maven plugin aren't playing nicely one with > > another. I'll try to fix it somewhere this week, possibly tomorrow, so we > > can start the release vote ASAP with RC2 artifacts. If someone wants to > > step in and fix it, please do it. > > > > > > thx and apologies for the delay, > > juan pablo >
