juanpablo-santos commented on a change in pull request #133:
URL: https://github.com/apache/jspwiki/pull/133#discussion_r738226297
##########
File path:
jspwiki-main/src/main/java/org/apache/wiki/management/SimpleMBean.java
##########
@@ -163,9 +163,9 @@ protected SimpleMBean() throws NotCompliantMBeanException
m_beanInfo = new MBeanInfo( getClass().getName(),
getDescription(),
attributes,
- constructors,
+ null,
Review comment:
same as before
##########
File path: jspwiki-main/src/main/java/org/apache/wiki/filters/SpamFilter.java
##########
@@ -568,8 +568,8 @@ private void checkAkismet( final Context context, final
Change change ) throws R
permalink,
commentType,
commentAuthor,
-
commentAuthorEmail,
-
commentAuthorURL,
+ null,
Review comment:
I'd rather use `commentAuthorEmail` and `commentAuthorURL` instead of
`null`, allows me to understand better what the method is expecting.
##########
File path:
jspwiki-main/src/main/java/org/apache/wiki/parser/JSPWikiMarkupParser.java
##########
@@ -2140,7 +2138,7 @@ private void fillBuffer( final Element startElement )
m_newLine = true;
disableOutputEscaping();
- while(!quitReading)
+ while(true)
Review comment:
same as previous ones; also, cfr. with next comment below
##########
File path:
jspwiki-markdown/src/main/java/org/apache/wiki/markdown/extensions/jspwikilinks/postprocessor/PluginLinkNodePostProcessorState.java
##########
@@ -125,7 +125,7 @@ void handleTableOfContentsPlugin(final NodeTracker state,
final JSPWikiLink link
toc.insertAfter( divsClosing );
} else {
- NodePostProcessorStateCommonOperations.inlineLinkTextOnWysiwyg(
state, link, m_wysiwygEditorMode );
+ NodePostProcessorStateCommonOperations.inlineLinkTextOnWysiwyg(
state, link, true );
Review comment:
same as before
##########
File path:
jspwiki-markdown/src/main/java/org/apache/wiki/markdown/extensions/jspwikilinks/postprocessor/InterWikiLinkNodePostProcessorState.java
##########
@@ -61,7 +61,7 @@ public InterWikiLinkNodePostProcessorState( final Context
wikiContext,
this.isImageInlining = isImageInlining;
this.inlineImagePatterns = inlineImagePatterns;
this.document = document;
- this.m_useOutlinkImage = wikiContext.getBooleanWikiProperty(
MarkupParser.PROP_USEOUTLINKIMAGE, m_useOutlinkImage );
+ this.m_useOutlinkImage = wikiContext.getBooleanWikiProperty(
MarkupParser.PROP_USEOUTLINKIMAGE, true);
Review comment:
same as before
##########
File path:
jspwiki-markdown/src/main/java/org/apache/wiki/markdown/extensions/jspwikilinks/postprocessor/ExternalLinkNodePostProcessorState.java
##########
@@ -48,7 +48,7 @@ public ExternalLinkNodePostProcessorState( final Context
wikiContext,
this.linkOperations = new LinkParsingOperations( wikiContext );
this.isImageInlining = isImageInlining;
this.inlineImagePatterns = inlineImagePatterns;
- this.m_useOutlinkImage = wikiContext.getBooleanWikiProperty(
MarkupParser.PROP_USEOUTLINKIMAGE, m_useOutlinkImage );
+ this.m_useOutlinkImage = wikiContext.getBooleanWikiProperty(
MarkupParser.PROP_USEOUTLINKIMAGE, true);
Review comment:
same as others before, is more readable for me if the variable is used
instead of a hardcoded value.
##########
File path:
jspwiki-main/src/main/java/org/apache/wiki/parser/JSPWikiMarkupParser.java
##########
@@ -2156,10 +2154,6 @@ private void fillBuffer( final Element startElement )
{
if( handleClosebrace() == null ) m_plainTextBuf.append(
(char) ch );
}
- else if( ch == -1 )
Review comment:
removing line 2146 `if( ch == -1 ) break;` and keeping this condition
with the original code at line 2143 is more readable (at least for me)
##########
File path:
jspwiki-markdown/src/main/java/org/apache/wiki/markdown/extensions/jspwikilinks/postprocessor/JSPWikiLinkNodePostProcessor.java
##########
@@ -58,7 +58,7 @@ public JSPWikiLinkNodePostProcessor( final Context m_context,
linkOperations = new LinkParsingOperations( m_context );
this.isImageInlining = isImageInlining;
this.inlineImagePatterns = inlineImagePatterns;
- m_useOutlinkImage = m_context.getBooleanWikiProperty(
MarkupParser.PROP_USEOUTLINKIMAGE, m_useOutlinkImage );
+ m_useOutlinkImage = m_context.getBooleanWikiProperty(
MarkupParser.PROP_USEOUTLINKIMAGE, true);
Review comment:
same as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
