Hi Carl, seems that the updated text didn't make it, it doesn't appear on the history page. Would you mind posting it here? We could make the review here and post it afterwards, wiki admins are excluded from the SpamFilter.
(Idea for anyone looking for a quick contrib: add to the SpamFilter the ability to also exclude certain groups/users, configurable through the jspwiki.properties file). Best regards, juan pablo El mié., 23 dic. 2020 17:26, Carl Marcum <cmar...@apache.org> escribió: > I should also mention the text and links for the old docker hub image will > need updated once the new one is available. > I would take care if that also. > > Thanks, > Carl > > On 12/23/20 11:23 AM, Carl Marcum wrote: > > Hi Juan Pablo, > > Thanks for the detailed information. > > It was a large change so It got caught by the Spam Filter. > I saved a copy of the original text in case you don't have versioning > enabled if you wanted it returned if you let it go for review. > > Thanks, > Carl > > On 12/23/20 9:13 AM, Juan Pablo Santos Rodríguez wrote: > > Hi Carl, > > the pages available on github are the minimum set of pages expected by a > fresh installation JSPWiki. Content stored at > jspwiki-wiki.a.o is delivered by a JSPWiki installation running on a > specific vm set up by infra, and its pages are stored > on a file dir in there. You should be able to create an account at > jspwiki-wiki.a.o and edit the page yourself; at worst, you > may be caught by the SpamFilter (if new text is unusually long or has too > many links) but most of the time it should be fine. > > As for review, either posting the text here, reviewing and then editing > the text at jspwiki-wiki.a.o or directly making the changes > there and asking for review here would be fine (at least for me, don't > know about other team members), so whatever you feel > comfortable with will be ok :-) > > > cheers, > juan pablo > > On Tue, Dec 22, 2020 at 10:19 PM Carl Marcum <cmar...@apache.org> wrote: > >> Hi all, >> >> I have reworked the Docker.txt page from the Wiki but I can't seem to >> find it in the source trees. >> >> Have I overlooked it or are not all the Wiki pages in Git? >> >> If not I can also just post the page text here and you can review. >> >> Best regards, >> Carl >> >> >> On 12/22/20 9:54 AM, Carl Marcum wrote: >> > Hi All, >> > >> > I'm working on a PR for the Docker page I should have ready sometime >> > today. >> > >> > Thanks, >> > Carl >> > >> > On 12/21/20 1:15 PM, Harry Metske wrote: >> >> thanks for following up, I will delete that (my personal) repo to >> >> prevent >> >> future misunderstandings. >> >> >> >> cheers, >> >> Harry >> >> >> >> On Mon, 21 Dec 2020 at 17:36, Carl Marcum <cmar...@apache.org> wrote: >> >> >> >>> Hi Juan Pablo, >> >>> >> >>> Thanks for redirect. That's quite a bit different. >> >>> I will fork that repo instead and work on it. >> >>> >> >>> If I see something I think will help I'll be back :) >> >>> >> >>> Best regards, >> >>> Carl >> >>> >> >>> On 12/21/20 11:17 AM, Juan Pablo Santos Rodríguez wrote: >> >>>> Hi Carl, >> >>>> >> >>>> the Dockerfile was moved on to the main repo on 2.11.0.M6, you cand >> >>>> find it at [#1]. Related documentation at jspwiki-wiki.a.o [#2] is >> >>>> still outdated, tough, and needs some work to reflect current status. >> >>>> >> >>>> In any case, we'd love if you could take a look at [#1] and send any >> >>>> PRs you see fit to make it better! :-) >> >>>> >> >>>> >> >>>> Thanks + best regards, >> >>>> juan pablo >> >>>> >> >>>> >> >>>> [#1]: https://github.com/apache/jspwiki/blob/master/Dockerfile >> >>>> <https://github.com/apache/jspwiki/blob/master/Dockerfile> >> >>>> [#2]: https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker >> >>>> <https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker> >> >>>> >> >>>> On Mon, Dec 21, 2020 at 2:23 PM Carl Marcum <cmar...@apache.org >> >>>> <mailto:cmar...@apache.org>> wrote: >> >>>> >> >>>> Hi All, >> >>>> >> >>>> I've forked the docker-jspwiki [1] from github and was wondering >> >>>> if you >> >>>> might want anything I'm working on PR'd back. >> >>>> >> >>>> Some of the things I'm looking at are: >> >>>> >> >>>> 1. Using the Dockerfile to download binaries and remove them. >> >>>> >> >>>> I noticed the Docker file comments mention CentOS 7 but the >> >>>> image is >> >>>> Alpine so I didn't know if that was a planned change. >> >>>> 2. a. Using a CentOS based image and adding a JRE >> >>>> b. Amazon Corretto based on Amazon Linux 2 optimized for >> AWS. >> >>>> c. Just start with an official Tomcat image (many OS >> >>>> options with >> >>>> this one). >> >>>> >> >>>> 3. Reducing the number of image layers through command >> >>>> consolidation. >> >>>> >> >>>> Also is branch 2.11.0-M5 the latest branch? >> >>>> >> >>>> Thanks, >> >>>> Carl >> >>>> >> >>>> [1] https://github.com/metskem/docker-jspwiki >> >>>> <https://github.com/metskem/docker-jspwiki> >> >>>> >> >>>> Best regards, >> >>>> Carl >> >>>> >> >>> >> > >> >> > >
