Hi, I'd prefer not to have optional markup, as it would lead to more complex setups / things to have in mind when setting up JSPWiki. Also we're in the middle of transitioning to 2.11 so breaking changes should be expected, as long as their clearly depicted on the NewIn.. page.
Also, in this particular case the alternative feels cumbersome, so it looks to me as a welcome addition, and is likely to break not too much wikipages (%%% not being a typical text for a wiki page). Again, in this case, people upgrading should check the NewIn.. page for all kinds of changes. In any case, that's my opinion only, what do you people think? best regards, juan pablo On Sat, Apr 6, 2019 at 1:14 AM Murray Altheim <murra...@altheim.com> wrote: > Hi, > > I'm fine with this proposal so long as it's a feature with a default of > false. As JSPWiki has been around for a very long time and has had a > lot of bespoke extensions created by people (many or most we may not even > know about) it's possible that a change of syntax like this could break > existing installations, where a plugin or extension isn't prepared for a > change of syntactical interpretation, such as a triple-"%". > > For those who want this new feature it could be enabled by setting a > property in jspwiki-custom.properties. That would be the safe approach. > > Principle of least surprise, etc. > > Cheers, > > Murray > > > > https://issues.apache.org/jira/browse/JSPWIKI-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > ] > > > > brushed updated JSPWIKI-1040: > > ----------------------------- > > Summary: Add new markup (%%% ... /%) for marking plain-text sections > > (was: Add new markup (%%% ... /%%) for marking plain-text sections ) > > > >> Add new markup (%%% ... /%) for marking plain-text sections > >> ------------------------------------------------------------ > >> > >> Key: JSPWIKI-1040 > >> URL: https://issues.apache.org/jira/browse/JSPWIKI-1040 > >> Project: JSPWiki > >> Issue Type: Improvement > >> Components: Core & storage > >> Reporter: brushed > >> Priority: Minor > >> > >> JSPWiki uses the following pattern to mark a block of text, to apply > >> different styles (eg. %%info) or as a trigger for a javascript handler > >> adding certain behaviour (eg. %%viewer) > >> {noformat} > >> %%<some-marker> ... /% > >> {noformat} > >> Note that the text inside the %% block continues to be parsed as regular > >> JSPWiki text. (eg. \[links] are properly converted to <a>; explicit > >> line-breaks, etc...) > >> For some use-cases, it would be convenient to be able to mark certain > >> sections in a page indicating that the text inside the section should > >> NOT be parsed by JSPWiki. > >> This is similar to a pre-formatted text block enclosed in triple curly > >> braces but then with different styling. > >> Today's workaround is to try to escape any possible markup conflict > >> (with tilde character) or to combine both syntaxes like this: > >> {noformat} > >> %%<some-marker> > >> {{{ > >> ... > >> }}} > >> /% > >> {noformat} > >> Both solutions are cumbersome and not trivial to the user. > >> ---- > >> The proposed syntax is to use a triple % sign: > >> {noformat} > >> %%%<some-marker> > >> .... plain vanilla text, remains unparsed by jsp-wiki > >> /% > >> {noformat} > >> Example use-case: > >> - mark a block of Tex/LaTeX syntax, and have some JS to render the math > >> - add an exotic markup language converter written in javascript > >> (markdown, pod, ...) > >> - etc. > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v7.6.3#76005) > > > > > > > > ........................................................................... > Murray Altheim <murray18 at altheim dot com> = = === > http://www.altheim.com/murray/ === > === > = = === > In the evening > The rice leaves in the garden > Rustle in the autumn wind > That blows through my reed hut. > -- Minamoto no Tsunenobu > > > >
