Hi! IIUC, the build will be triggered every time there is a tag made. When we start a vote for X.Y.Z, we tag "tentatively" X.Y.Z-RC# (and later on when the vote passes we re-tag X.Y.Z-RC# to X.Y.Z). So we'd likely end up with failing builds more often than not, because binaries aren't available yet at RC stage.
So I was thinking that we could request another git repo for the docker build; that way we could grab the binaries from either https://dist.apache.org/repos/dist/release/jspwiki/$VERSION/etc., central or https://repository.apache.org/service/local/artifact/maven/redirect?r=releases&g=org.apache.jspwiki&a=jspwiki-war&v=$VERSION&e=war The downside is that it would require another vote thread to release the docker build, which seems a little cumbersome. Another option could be downloading the tag and building the project as part of the Dockerfile (a multi-stage build). Seems to me a little too much, for just obtaining the binaries, but OTOH it would allow us to have all the source under one git repo. sounds feasible? br, juan pablo On Sun, Aug 5, 2018 at 7:36 PM, Harry Metske <harry.met...@gmail.com> wrote: > I went through this, and if I am correct we could: > * create a Dockerfile in our jspwiki project, for example: > /docker/dockerhub/Dockerfile > * request docker automated build with info: > > Type: "Tag" > Name: "/jspwiki_(\d+\_\d+\_\d+)/" > Dockerfile location: "/docker/dockerhub" > Docker tag name: "{\1}" > > And the Dockerfile should be changed in such a way that the 2 added > binaries (JSPWiki.war and jspwiki-wikipages.zip) are being fetched from a > remote location (pick an apache mirror site). > I wonder if that will work, I don't if we can find a download location > where the binaries will be present when the docker build is run > (automatically when we git push the new tag). > > cheers, > Harry > > > On Wed, 1 Aug 2018 at 19:27, Juan Pablo Santos Rodríguez < > juanpablo.san...@gmail.com> wrote: > > > Hi, > > > > searching for some documentation about Docker (ASF Infra) support, I've > > stumbled upon some interesting infra JIRAs, namely: > > - https://jira.apache.org/jira/browse/INFRA-13838 > > - https://jira.apache.org/jira/browse/INFRA-12781 > > - https://jira.apache.org/jira/browse/INFRA-14586 > > > > requesting automated builds under Apache Dockerhub account. The applying > > release policy would be > > https://www.apache.org/dev/release-distribution.html#unreleased, but > other > > than that, moving the JSPWiki's Docker > > support [#1] into the Apache Dockerhub account would be a nice addition > for > > upcoming 2.10.5. Harry, WDYT? > > > > > > tx + br, > > juan pablo > > > > [#1] https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker > > >
