yup, I ll do that somewhere today cheers, Harry
Op wo 20 jun. 2018 om 19:40 schreef Dirk Frederickx < dirk.frederi...@gmail.com> > Harry, Juan, > > I made a commit earlier this week to resolve the hover/clickable buttons > for devices with a touch-interface. > Would it be possible to push the update to jspwiki-wiki.apache.org . > Testing was done on iPad/iPhone, but I'd like to get feedback on other > types of touch devices. > > > Not sure how to close the issue on github. > > > br, > dirk > > > > On Tue, May 29, 2018 at 6:45 PM Harry Metske <harry.met...@gmail.com> > wrote: > > > I had seen it before on the dev list. > > But since it was mostly frontend, I did not comment. > > > > cheers, > > Harry > > > > > > On Tue, 29 May 2018 at 00:40, Juan Pablo Santos Rodríguez < > > juanpablo.san...@gmail.com> wrote: > > > > > Hi, > > > > > > I was looking for the below mail at [user|dev|commits]@jspwiki.a.o. As > I > > > can't see it through Pony Mail, I'm resending over > > > dev. Would anyone mind confirming if this is the first time receiving > the > > > e-mail? (if not, apologies for the noise). > > > > > > And regarding the PR itself, any thoughts on it? I find it useful, esp. > > for > > > mobile devices, and would be +1 for merging it, > > > but I don't have a strong opinion on it, frontend isn't one of my key > > > points.. > > > > > > > > > thanks in advance, > > > juan pablo > > > > > > > > > ---------- Forwarded message ---------- > > > From: jonasmue <notificati...@github.com> > > > Date: Fri, May 25, 2018 at 1:35 PM > > > Subject: [apache/jspwiki] Clickable buttons (#1) > > > To: apache/jspwiki <jspw...@noreply.github.com> > > > Cc: Subscribed <subscri...@noreply.github.com> > > > > > > > > > Made header buttons clickable instead of hoverable. This change should > > > result in increased usability since the opening boxes frequently would > > have > > > been closed involuntarily if user's mouse movement was not precise > enough > > > after hovering over the buttons. Removed the carets for consistency > > reasons > > > as they indicate a hoverable target. > > > ------------------------------ > > > You can view, comment on, or merge this pull request online at: > > > > > > https://github.com/apache/jspwiki/pull/1 > > > Commit Summary > > > > > > - Clickable header buttons > > > - Updated to current state and removed other changes > > > - Changed indentation to original form > > > > > > File Changes > > > > > > - *M* jspwiki-war/src/main/scripts/wiki/Wiki.js > > > <https://github.com/apache/jspwiki/pull/1/files#diff-0> (35) > > > - *M* jspwiki-war/src/main/webapp/templates/haddock/SearchBox.jsp > > > <https://github.com/apache/jspwiki/pull/1/files#diff-1> (4) > > > - *M* jspwiki-war/src/main/webapp/templates/haddock/UserBox.jsp > > > <https://github.com/apache/jspwiki/pull/1/files#diff-2> (4) > > > > > > Patch Links: > > > > > > - https://github.com/apache/jspwiki/pull/1.patch > > > - https://github.com/apache/jspwiki/pull/1.diff > > > > > > — > > > You are receiving this because you are subscribed to this thread. > > > Reply to this email directly, view it on GitHub > > > <https://github.com/apache/jspwiki/pull/1>, or mute the thread > > > < > > > > > > https://github.com/notifications/unsubscribe-auth/ABKX4v23eYQ0kCinSJj1cWhts1HVqYbUks5t1-yBgaJpZM4UN0uj > > > > > > > . > > > > > >
