On 23/05/18 06:59, Juan Pablo Santos Rodríguez wrote:
Hi Brian,
seems you've hit https://issues.apache.org/jira/browse/SUREFIRE-1439
(NullPointerException on JDK10) which is fixed on the 2.21.0 version of the
surefire plugin. JSPWiki itself should compile and run ok at least with JDK
6 to 8, haven't tried with 9, and as you have seen doesn't run tests with
10.. I'll bump the surefire version as soon as the vote moves on, unless
anyone beats me to it.
Thanks for taking the time to look at my problem, Juan-Pablo. I'm away
and won't have time to revive java 8 on my new laptop. By the time I get
back to my office until the vote will have ended, so I can't contribute
this time. All I can say is I've checked the packaging and it behaves
the same way as the git branch!
I'm pleased everyone is happy with the new release and I look forward to
implementing it on my production system.
Shall I add a note to the "Building from source code" page about how to
clone a branch or tag?
Oh yes, you didn't say anything about the use of <jdk.version> im the
top-level pom.xml. Does the project use "Spring Boot" (I thought not),
because otherwise it is just a no-op.
Thanks again,
Brian
HTH,
juan pablo
ps: if your plugin is oss, drop us a line so it gets included on
https://jspwiki-wiki.apache.org/Wiki.jsp?page=ContributedPlugins :-)
On Tue, May 22, 2018 at 9:18 AM, Brian Burch <br...@pingtoo.com> wrote:
On 21/05/18 05:11, Juan Pablo Santos Rodríguez wrote:
This is a release vote for Apache JSPWiki, version 2.10.4. The vote will
be
open for at least 72 hours from now.
It fixes the following issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
ctId=12310732&version=12342771
Note that we are voting upon the source (tag), binaries are provided for
convenience.
Everybody is encouraged to vote.
I have been intending to upgrade my jspwiki installation for a long time,
but I know this will require a lot of work to upgrade my own jspwiki
plugin. I keep putting it off, but decided a "quick build and test" of the
2.10.4-RC3 would be helpful for me, and a contribution to the project.
It hasn't worked out and my first reaction was to forget it and say
nothing to the develpers. However, I decided it might be helpful to others
if I mention what happened. It is probably just down to me being in a hurry
and away from home and my normal development environment, but I am
surprised I failed so spectacularly.
Firstly, I simply downloaded the source zip using the url below: a simple
"mvn clean test" in the jspwiki-builder-2.10.4 directory failed very
quickly. I didn't spend long on the failure and I don't think it would be
productive for you to go through the trace, so here is just the first line
for anyone interested:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test
(default-test) on project jspwiki-war: Execution default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.:
NullPointerException -> [Help 1]
I quickly moved on to checkout the source from git and build it myself. I
went to the JSPWIKI wiki "Building from source code" page, but discovered
it doesn't say how to clone a tag. I used:-
git clone --branch 2.10.4-RC3 https://github.com/apache/jspwiki.git
jspwiki
That worked, and my "mvn clean test" failed yet again! In the middle of
the stack trace were these two lines:
Caused by: java.lang.NullPointerException
at org.apache.maven.surefire.shade.org.apache.commons.lang3.
SystemUtils.isJavaVersionAtLeast (SystemUtils.java:1626)
A quick check of pom.xml showed the property <jdk.version>1.6</jdk.version>
and this was confirmed by the "Getting Started" wiki page Requirements
section: JDK 1.6 or higher (1.7 if using Markdown Support).
My long-serving laptop died completely a few months ago. I can't remember
when I last built jspwiki on it, but the version was 2.10.0. I am slowly
recreating a development environment from backup and an upgrade to ubuntu
18.04.
I vaguely remember a dev list discussion about java versions, but don't
recall whether that was the jspwiki or apacheds project! I googled for
anything relevant, but just found the references I knew about already.
At the moment, my default jdk is:-
ii openjdk-11-jdk:amd64 10.0.1+10-3ubuntu1
amd64 OpenJDK Development Kit (JDK)
and "javac --version" reports: javac 10.0.1.
I found a few clues that I last used java 8 on the dead laptop.
Is that my problem? Am I trying to build and test on a version of java
which is too new? If yes, what is the latest version that ought to be
referenced in the README, wiki, etc?
I wondered.. Isn't there a more graceful way to constrain the compiler and
remembered having to so for my own projects a long time ago (java 1, 1.1,
1.3.. does anyone remember those days?)
More googling found a very interesting item:
https://stackoverflow.com/questions/38882080/specifying-java
-version-in-maven-differences-between-properties-and-compiler-p/38883073
In particular, the "old way" is best, using the maven-compiler-plugin
<source> and <target> properties, or even the global properties
<maven.compiler.source> (or target).
I don't fully understand the comment that the pom.xml property
<java.version> (as used by jspwiki and specified as 1.6) "is not mentioned
in the Maven documentation and is a Spring Boot specificity".
JDKs 9 and 10 ought to be happy working with 1.6 source and targets, so am
I looking at the problem from the wrong angle?
Sorry if I am just blowing smoke over the new release. I /was/ trying to
be helpful!
Regards,
Brian
Source and binary files:
https://dist.apache.org/repos/dist/dev/jspwiki/2.10.4-rc3
Nexus staging repo:
https://repository.apache.org/content/repositories/orgapachejspwiki-1005
The tag to be voted upon:
https://github.com/apache/jspwiki/tree/2.10.4-RC3
JSPWiki's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/jspwiki/KEYS
*** Please download, test and vote:
[ ] +1 Approve the release
[ ] 0 Don't mind
[ ] -1 Disapprove the release (please provide specific comments)
