We have to add reactor because we should implement https://github.com/micronaut-projects/micronaut-security/blob/master/security/src/main/java/io/micronaut/security/authentication/AuthenticationProvider.java which returns https://micronaut-projects.github.io/micronaut-security/2.4.0/api/io/micronaut/security/authentication/AuthenticationProvider.html. I don't see any implementations in the project right now.
On Fri, Feb 3, 2023 at 6:18 PM Михаил Початкин <m.a.pochat...@gmail.com> wrote: > Hi, Ivan. > > I don't see any problems with adding *micronaut-security* in the context of > the IGNITE-18575 epic of security implementation. Moreover, we already have > several micronaut modules in dependencies (micronaut-inject, > micronaut-runtime, micronaut-validation, micronaut-http, etc) and I think > that we should not deviate from a single ecosystem. I would also like to > see the answer to Alexander's question about the reactor dependency. > > Thanks! > > пт, 3 февр. 2023 г. в 12:11, Aleksandr Pakhomov <apk...@gmail.com>: > > > Hi Ivan, > > > > Why do we add reactor dependency? The Ignite 3 codebase > > uses java async API. Just wonder to know it we could escape > > the usage of third party async libraries. > > > > -- > > Best regards, > > Aleksandr > > > > > On 3 Feb 2023, at 10:51, Ivan Gagarkin <gagarkin....@gmail.com> wrote: > > > > > > I'd like to add a few 3rd party libraries to Ignite 3 > > > > > > 1. Micronaut Security > > > > https://micronaut-projects.github.io/micronaut-security/latest/guide/ > > > 2. Micronaut Reactor > > > https://micronaut-projects.github.io/micronaut-reactor/latest/guide/ > > > > > > We have to have them for authentication and authorization in the REST. > > > https://issues.apache.org/jira/browse/IGNITE-18576 > > > > > > WDYT? Any objections? Also, comments on IEP-87 are welcomed. > > > -- > > > Best Regards, Ivan > > > > > > -- > С уважением, > Початкин Михаил. > -- Best Regards, Ivan
