Hi Misha.

Thank you for your valid points.

I accept your suggestion about "ignite cli config get/set" naming.
As for default commands, I think "clear" and "exit" are only for REPL mode and 
I'll add them to the description of the commands. "ignite help" is already 
defined there.

> On 13 May 2022, at 17:04, Mikhail Pochatkin <mpochat...@unison.team> wrote:
> 
> Hello, Sasha.
> 
> The description looks good to me, only a few comments.
> 
> 1. I would suggest renaming the CLI configuration command. Currently
> "ignite default get" and "ignite default set" look not informative. I
> understand that "ignite config" is already used for the Ignite
> configuration command and this is a problem to find another good name for
> this command. My suggestion is "ignite cli config", if anyone has a better
> variant, you are welcome.
> 2. I think that Ignite CLI should also have default commands like "ignite
> help", "ignite clear", "ignite exit" and etc. Could you please add topics
> about these commands.
> 
> On Thu, May 12, 2022 at 11:43 PM Aleksandr Pakhomov <apk...@gmail.com>
> wrote:
> 
>> Hello, Igniters.
>> 
>> I’d like to start a discussion about Ignite 3 Command Line Tool [1]. The
>> main value is to develop a user-friendly command-line tool with advanced
>> completions and SQL REPL mode.
>> 
>> The set of commands and parameters can be discussed. Questions and
>> comments are welcomed.
>> 
>> [1] https://cwiki.apache.org/confluence/display/IGNITE/IEP-88%3A+CLI+Tool
>> <https://cwiki.apache.org/confluence/display/IGNITE/IEP-88:+CLI+Tool>

Reply via email to