LGTM. Merged to master. Thank you for your contribution!
On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mmu...@apache.org> wrote: > Folks, > > This is a friendly reminder :-) > PR [1] is ready for review. Will anyone take a look? > > [1] https://github.com/apache/ignite/pull/9577/files > > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mmu...@apache.org> wrote: > > > > Folks, > > > > > > I've prepared the changes related to the legacy Service Grid removal > > for the 2.13 release. Here is the issue [1] and the PR [2] of these > > changes. > > > > Some important notes: > > > > - Removed GridServiceProcessor legacy implementation (internal) > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property > > was removed (this is a breaking change) > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was > > removed (this is a breaking change) > > - The node with 2.13 won't be able to connect to 2.12 (assume Ignite > > services are used) > > > > The legacy test suite [3] will be removed after the [1] issue will be > merged. > > > > > > Who can take a look at this PR? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15758 > > [2] https://github.com/apache/ignite/pull/9577/files > > [3] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode > > > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <nizhi...@apache.org> > wrote: > > > > > > Hello. > > > > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the > following API are prepared: > > > > > > 1. MVCC > > > - https://issues.apache.org/jira/browse/IGNITE-15757 > > > - https://github.com/apache/ignite/pull/9516 > > > > > > 2. LOCAL caches > > > - https://issues.apache.org/jira/browse/IGNITE-15756 > > > - https://github.com/apache/ignite/pull/9515 > > > > > > 3. CacheConfiguration#rebalanceDelay > > > - https://issues.apache.org/jira/browse/IGNITE-15764 > > > - https://github.com/apache/ignite/pull/9515 > > > > > > Please, review. > > > > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov <nizhikov....@gmail.com> > написал(а): > > > > > > > > THanks, Maksim. > > > > > > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13 > > > > > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mmu...@apache.org> > написал(а): > > > >> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also. > > > >> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662 > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613 > > > >> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <a...@apache.org> > wrote: > > > >>> > > > >>> +1 > > > >>> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev < > namelc...@apache.org> > > > >>> wrote: > > > >>> > > > >>>> +1 for deprecation in the 2.12 release > > > >>>> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <nizhi...@apache.org > >: > > > >>>>> > > > >>>>> Hello, Igniters. > > > >>>>> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that should > be done > > > >>>> in Ignite 2.x. > > > >>>>> > > > >>>>> We agreed on the following algorithm to deal with breaking > changes: > > > >>>>> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the users. > > > >>>>> - Ignite 2.[x+1] - API removal. > > > >>>>> > > > >>>>> > > > >>>>> I propose to start these improvements with the d&r (depuration & > > > >>>> removal) of the following features: > > > >>>>> > > > >>>>> - LOCAL caches > > > >>>>> - MVCC caches > > > >>>>> - legacy service grid implementation > > > >>>>> - legacy JMX metrics beans. > > > >>>>> > > > >>>>> Deprecation in 2.12 > > > >>>>> Removal in 2.13 > > > >>>>> > > > >>>>> Please, share your opinion. > > > >>>>> > > > >>>>> [1] > > > >>>> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475 > > > >>>> > > > >>>> > > > >>>> > > > >>>> -- > > > >>>> Best wishes, > > > >>>> Amelchev Nikita > > > >>>> > > > > > > > > -- Best Regards, Vyacheslav D.
