Hi, Andrey! Thank you for your reply.
I had the same thought about special system-region-configuration-class, but then I discovered that we have 3 special regions: sysMemPlc, volatileDsMemPlc, metastoreMemPlc. *If we decide to provide a special type* for configuration, then should it be *one* type for all special regions but *different* instances, or should the user provide *one* instance of system-region-configuration-class, or maybe even *different* type for each special region? My heart aligns with the first option. Or maybe it is better to stick to the initial plan: only make new holes in *DataStorageConfiguration?* On Tue, 2 Nov 2021 at 17:40, Andrey Gura <ag...@apache.org> wrote: > Hi, > > Your proposal is consistent with the current interface of > DataStorageConfiguration class, so I', okay with the proposed change. > > Alternatively, DataStorageConfiguration#systemDataRegionConfiguration > field could be introduced which could be DataRegionConfiguration type > or special SystemDataRegionConfiguration type in case if we want to > limit access to the system data region parameters. > > On Tue, Nov 2, 2021 at 2:42 PM Eduard Rakhmankulov <erixon...@gmail.com> > wrote: > > > > Hello, Igniters! > > > > At the moment metrics on system region are disabled on node start. > > User-defined regions can be tuned to have enabled metrics via region > > configuration > > > (org.apache.ignite.configuration.DataRegionConfiguration#setMetricsEnabled) > > To enable metrics on system region users should use non-public API or use > > deprecated JMX bean > > (org.apache.ignite.mxbean.DataRegionMetricsMXBean#enableMetrics) for it, > > which doesn't solve problem because it needs human attention when node > > restarts. > > > > I want to add a new property to > > *org.apache.ignite.configuration.DataStorageConfiguration* which enables > or > > disables collection of metrics on system region (aka sysMemPlc) on node > > start. > > > > API change > > add new public methods: > > > > 1. > > > *org.apache.ignite.configuration.DataStorageConfiguration#isSystemRegionMetricsEnabled()* > > 2. > > > *org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionMetricsEnabled(boolean)* > > > > > > WDYT? > > -- > > Best regards, Eduard. >
