+0.5 from me 1. Checked signatures and sha512 sums -- both OK 2. Both source packages compiles and tests passed -- OK 3. Manually created examples project from provided examples in spring-tx-ext -- works OK with spring 5.3.11 (with manual exclusion of spring dependencies) - OK 4. Checked previous step with jars from staging repo -- OK
Unfortunately, there aren't any examples in spring-cache-ext, so I skipped part of checking jar staging. I suppose, that in the next releases examples should be improved 1. Create separate maven project for them 2. Provide examples for every releasing module. These steps can improve release verification process and very handy for users. Also, +1 for Anton, release artifacts should be built on TC, not manually. ср, 27 окт. 2021 г. в 12:26, Anton Vinogradov <a...@apache.org>: > My -0 here, since the is no automated RC preparation and testing at Apache > TeamCity again. > Next time, I will vote with -1 if a new vote is not covered by public > automated preparation/testing as the AI release does. > > On Wed, Oct 27, 2021 at 11:48 AM Nikita Amelchev <namelc...@apache.org> > wrote: > > > Dear Ignite Community, > > > > I have uploaded a release candidate of extensions modules: > > - spring-tx-ext 1.0.0 > > - spring-cache-ext 1.0.0 > > - spring-data-commons 1.1.0 > > > > The following staging can be used for testing: > > https://repository.apache.org/content/repositories/orgapacheignite-1533 > > > > The release candidate of the spring-tx-ext 1.0.0 extension: > > > > > https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-tx-ext/1.0.0-rc1/ > > > > The release candidate of the spring-cache-ext 1.0.0 extension: > > > > > https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-cache-ext/1.0.0-rc1/ > > > > The release candidate of the spring-data-common 1.1.0 dependent module > > is in the packages mentioned above. > > > > Tags were created: > > ignite-spring-tx-ext-1.0.0-rc1 > > ignite-spring-cache-ext-1.0.0-rc1 > > ignite-spring-data-commons-1.1.0-rc1 > > > > > > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=refs/tags/ignite-spring-tx-ext-1.0.0-rc1 > > > > RELEASE NOTES: > > > > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=c6b2a393e042ce956bfefd5d7d92d5ab4ff04cda;hb=HEAD > > > > DOCUMENTATION: > > Documentation of the spring-tx-ext extension: > > > > > https://github.com/apache/ignite/blob/master/docs/_docs/extensions-and-integrations/spring/spring-tx.adoc > > > > Documentation of the spring-cache-ext extension: > > > > > https://github.com/apache/ignite/blob/master/docs/_docs/extensions-and-integrations/spring/spring-caching.adoc > > > > The vote is formal, see voting guidelines > > https://www.apache.org/foundation/voting.html > > > > +1 - to accept the extensions modules listed in the thread > > 0 - don't care either way > > -1 - DO NOT accept either of the extensions modules listed in the > > thread (explain why) > > > > The vote will hold for 5 days and will end on November 1, 2021, 10:00 UTC > > https://www.timeanddate.com/countdown/generic?iso=20211101T10&p0=0 > > > > -- > > Best wishes, > > Amelchev Nikita > > > -- Sincerely yours, Ivan Daschinskiy
