>> Btw, I was always against moving thin clients into separate repos. Monorepo Monorepo is a mostly cargo cult. What is suitable for google is not suitable for others. For example, we have already released new versions of pyignite with many new features. When this client was in our super repo, it was not released and published for years.
вт, 17 авг. 2021 г. в 18:32, Pavel Tupitsyn <ptupit...@apache.org>: > Ivan, > > 1. It will be clean. It will actually be better: good to know when build > failure is caused by a config change, right? > > 2. Can you please provide an example in a well-known open-source project > other than Ignite? > > Btw, I was always against moving thin clients into separate repos. Monorepo > approach in some large companies is used for a reason. > Dealing with multiple repositories is always hard. > > > On Tue, Aug 17, 2021 at 6:23 PM Ivan Daschinsky <ivanda...@gmail.com> > wrote: > > > 1. Clean commit history (As one developer said, git history is an api) > > 2. We have separate thin client repos -- but TC thin client build depends > > on ignite build also. > > > > > > вт, 17 авг. 2021 г. в 18:08, Pavel Tupitsyn <ptupit...@apache.org>: > > > > > Ivan, > > > > > > > I'm sorry, but what about storing TC configs in separate repo? > > > What are the pros of this approach? What do we gain? > > > Separate repo always adds friction, and it is not clear how to handle > > > config changes that are tied to code changes. > > > > > > > It is quite common approach. > > > Can you provide an example of an open-source project with this > approach? > > > > > > On Tue, Aug 17, 2021 at 6:05 PM Ivan Daschinsky <ivanda...@gmail.com> > > > wrote: > > > > > > > I'm sorry, but what about storing TC configs in separate repo? > > > > It is quite common approach. > > > > > > > > вт, 17 авг. 2021 г. в 17:33, Pavel Tupitsyn <ptupit...@apache.org>: > > > > > > > > > Anton, > > > > > > > > > > > This will kill repo history. > > > > > > You'll see dozens of TC config updates vs a single Ignite fix > > > > > > > > > > Not really. > > > > > I'm not suggesting something crazy, this is the modern way to do > > CI/CD > > > > > - see GitHub actions, Azure pipelines, etc - you write a config and > > > store > > > > > it in Git. > > > > > > > > > > > Where are you going to apply configs, do you have your own TC? ;) > > > > > > > > > > Maybe I do. That's the point, no matter how many TCs we have, all > of > > > them > > > > > will use the same configs from the repo. > > > > > > > > > > On Tue, Aug 17, 2021 at 5:07 PM Petr Ivanov <mr.wei...@gmail.com> > > > wrote: > > > > > > > > > > > After initial setup, there won't be lot's of changes, at least > for > > > PRs > > > > > > there will be single commit with both fix and TC changes. > > > > > > > > > > > > > > > > > > > On 17 Aug 2021, at 13:05, Anton Vinogradov <a...@apache.org> > > wrote: > > > > > > > > > > > > > > This will kill repo history. > > > > > > > You'll see dozens of TC config updates vs a single Ignite fix > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Sincerely yours, Ivan Daschinskiy > > > > > > > > > > > > > -- > > Sincerely yours, Ivan Daschinskiy > > > -- Sincerely yours, Ivan Daschinskiy
