Hi Nikolai, thank you for noticing. I guess it's not about license, but about Intellectual Property (IP) ownership.
AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be used in the codebase for an Apache project (https://www.apache.org/legal/resolved.html) But licenese and IP owner are 2 sligthly different things. E.g at the end of any website you can find: Copyright © 2021 The Apache Software Foundation, Licensed under the Apache License, Version 2.0. Incubated projects are mandated to transfer IP to the ASF. And I'm not aware of any exceptions. In this PR there are 5 classes which licenses with AL 2.0, but IP owner is 3rd party company. I'm a bit concerned about having such code in the project. I'd rather reverted it until we have approval from experts at mailing list: legal-disc...@apache.org Sincerely, Dmitriy Pavlov On 2021/06/22 14:56:49, Nikolay Izhikov <nizhi...@apache.org> wrote: > Hello, Igniters. > > Recently huge commit was merged [1]. > > Taras, Alexander, can you, please, explain what is purpose of the commit? > What feature it implemented? > > Looked inside the ticket and found no explanation. > Description is "Add statistics collection and usage.» > > Do we have plans to document this new feature? > > Also, I see very strange license in added files [2] > > ``` > * Copyright 2013 Aggregate Knowledge, Inc. > * > * Licensed under the Apache License, Version 2.0 (the "License"); > ``` > > Is it OK to have those copyright inside ASF codebase? > Is it some kind of external dependency we adopted as part of the code? > Why do we need it? > > [1] > https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb > [2] > https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
