Hello, Ilya.
Thank you for feedback.
Yes, the vote was cancelled. I have published results.
I will create issues and prepare RC4 after fixing them.
ср, 19 мая 2021 г., 12:58 Ilya Kasnacheev <ilya.kasnach...@gmail.com>:
> Hello!
>
> Do I understand correctly that voting did not succeed due to insufficient
> participation? Can you post the vote results?
>
> I have checked examples and it indeed works.
>
> I have a list of things to do before the RC4:
> Please copy over examples directory and pom.xml to spring module 2.2.
> There's no reason why spring data 2.0 should have examples but spring data
> 2.2 should not.
> Release a single zip file called spring-data-all-ext-1.0.0-src.zip with the
> zipped source. No reason to post the same source 4 times if we are
> releasing them all together.
> Put all files in archive in spring-data-all-ext-1.0.0-src/ directory. Top
> level in zip archive should have just 1 directory.
> README.md should not be a Readme of Apache Ignite. Better keep it short and
> write something about what's Apache Ignite Extensions and where to get
> them.
> Remove scripts/ directory and .gitignore.
> Make mvn -Pcheckstyle,check-licenses validate pass - currently it fails.
>
> I promise to help with release voting agitation if these points are met.
> They will also increase the quality of release greatly.
>
> I can file a ticket with these steps if you like, or you may track it
> yourself.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 17 мая 2021 г. в 18:07, Mikhail Petrov <pmgheap....@gmail.com>:
>
> > +1
> >
> > I created separate Spring Applications for each version of Spring Data
> > Integration using the RC repository and following the documentation. And
> > tested common use cases.
> >
> > On 14.05.2021 15:39, Nikita Amelchev wrote:
> > >> How do I actually run these examples?
> > > Use the 'examples' maven profile, please.
> > >
> > >> I don't understand why we are releasing four source ZIPs if their
> > contents are identical? Can we release a single one, name it
> > spring-data-all-ext-1.0.0-src.zip?
> > > Modules are independent. For example, we can release spring-data-ext
> > > v1.1 without releasing others. I think each module should have its
> > > independent sources.
> > >
> > >> Can we find a way to drop all non-relevant modules?
> > > I think we can use TC to prepare the build as well as the Ignite
> > > release process do it. I suggest using it in future releases when such
> > > a build appears.
> > >
> > > пт, 14 мая 2021 г. в 15:02, Ilya Kasnacheev <ilya.kasnach...@gmail.com
> >:
> > >> Hello!
> > >>
> > >> How do I actually run these examples? These do not seem to have a
> > pom.xml
> > >> of their own now.
> > >>
> > >> I don't understand why we are releasing four source ZIPs if their
> > contents
> > >> are identical? Can we release a single one, name it
> > >> spring-data-all-ext-1.0.0-src.zip? Can we find a way to drop all
> > >> non-relevant modules?
> > >>
> > >> All of the files need to be in one directory, such
> > >> as spring-data-all-ext-1.0.0-src/modules, etc, but they are located in
> > >> archive root, which differs from how we do it with Apache Ignite src
> > zip.
> > >>
> > >> Source release should differ from git repo dump: it does not need
> > >> .gitignore or scripts/ directory since these are of no use for source
> > >> distribution user.
> > >>
> > >> Regards,
> > >> --
> > >> Ilya Kasnacheev
> > >>
> > >>
> > >> пт, 14 мая 2021 г. в 14:32, Nikita Amelchev <namelc...@apache.org>:
> > >>
> > >>> Hello, Ilya.
> > >>>
> > >>>> Is there any way to find and run these examples with spring-data ext
> > >>> 1.0.0?
> > >>>
> > >>> Spring data modules were migrated to the extensions repo with their
> > >>> examples. Examples for 2.0 still available in the package:
> > >>>
> > >>>
> > >>>
> >
> modules/spring-data-2.0-ext/examples/main/java/org/apache/ignite/springdata20/examples/
> > >>>
> > >>> Other versions were not covered with examples.
> > >>>
> > >>>> I have also found that in spring-data 2.2 source archive at least,
> > >>> there's full git repo of ignite-ext including .gitignore, committer
> > >>> scripts, sources for all modules such as flink, but no spring data
> > examples.
> > >>>
> > >>> The source package is a full copy of the extensions repo as the build
> > >>> process requires the parent pom. Build instruction is mentioned in
> the
> > >>> DEVNOTES file.
> > >>>
> > >>> пт, 14 мая 2021 г. в 13:53, Ilya Kasnacheev <
> ilya.kasnach...@gmail.com
> > >:
> > >>>> Hello!
> > >>>>
> > >>>> We had Spring Data examples in 2.9 in the ZIP file:
> > >>>> examples/config/spring/example-spring-data.xml:
> > >>>>
> Ignition.start("examples/config/spring/example-spring-data.xml");
> > >>>>
> > >>>
> >
> examples/src/main/java/org/apache/ignite/examples/springdata/SpringApplicationConfiguration.java
> > >>>> : return
> > >>>> Ignition.start("examples/config/spring/example-spring-data.xml");
> > >>>>
> > >>>> examples/pom.xml:
> > >>> <artifactId>ignite-spring-data_2.0</artifactId>
> > >>>> Is there any way to find and run these examples with spring-data ext
> > >>> 1.0.0?
> > >>>> I have also found that in spring-data 2.2 source archive at least,
> > >>> there's
> > >>>> full git repo of ignite-ext including .gitignore, committer scripts,
> > >>>> sources for all modules such as flink, but no spring data examples.
> > >>>>
> > >>>> Please clarify.
> > >>>>
> > >>>> Regards,
> > >>>> --
> > >>>> Ilya Kasnacheev
> > >>>>
> > >>>>
> > >>>> ср, 12 мая 2021 г. в 18:28, Nikita Amelchev <namelc...@apache.org>:
> > >>>>
> > >>>>> Dear Ignite Community,
> > >>>>>
> > >>>>> I have uploaded a release candidate of the following extension
> > modules:
> > >>>>>
> > >>>>> spring-data-commons
> > >>>>> spring-data-ext
> > >>>>> spring-data-2.0-ext
> > >>>>> spring-data-2.2-ext
> > >>>>>
> > >>>>> The release candidate of the extensions:
> > >>>>>
> > >>>>> spring-data-commons
> > >>>>>
> > >>>>>
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-commons/1.0.0-rc3/
> > >>>>> spring-data-ext
> > >>>>>
> > >>>>>
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-ext/1.0.0-rc3/
> > >>>>> spring-data-2.0-ext
> > >>>>>
> > >>>>>
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-2.0-ext/1.0.0-rc3/
> > >>>>> spring-data-2.2-ext
> > >>>>>
> > >>>>>
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-2.2-ext/1.0.0-rc3/
> > >>>>> The instruction for building from the source package is placed in
> the
> > >>>>> DEVNOTES file.
> > >>>>>
> > >>>>> The following staging can be used for testing:
> > >>>>>
> > >>>
> > https://repository.apache.org/content/repositories/orgapacheignite-1515
> > >>>>> Tags were created:
> > >>>>>
> > >>>>> ignite-spring-data-commons-1.0.0-rc3
> > >>>>> ignite-spring-data-ext-1.0.0-rc3
> > >>>>> ignite-spring-data-2.2-ext-1.0.0-rc3
> > >>>>> ignite-spring-data-2.0-ext-1.0.0-rc3
> > >>>>> ignite-spring-data-all-ext-1.0.0-rc3
> > >>>>>
> > >>>>>
> > >>>
> >
> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=cfec73eeca94a675167751409e3203ce516c3b39
> > >>>>> RELEASE NOTES:
> > >>>>>
> > >>>>>
> > >>>
> >
> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=22f8d665c194ba2dfa6167354d97ad53d5ef206f;hb=c8de80ee14d1fb76d6cbb0b18513bb70b499c3cb
> > >>>>> DOCUMENTATION:
> > >>>>> Documentation of listed extensions was updated in the following
> > issues:
> > >>>>>
> > >>>>>
> > >>>
> >
> https://issues.apache.org/jira/issues/?filter=-1&jql=key%20in%20(IGNITE-14662%2CIGNITE-14398%2CIGNITE-14493)
> > >>>>> The vote is formal, see voting guidelines
> > >>>>> https://www.apache.org/foundation/voting.html
> > >>>>>
> > >>>>> +1 - to accept all the Apache Ignite spring-data-all-ext extensions
> > >>>>> 1.0.0-rc3 listed in the thread
> > >>>>> 0 - don't care either way
> > >>>>> -1 - DO NOT accept either of the Apache Ignite spring-data-all-ext
> > >>>>> extensions 1.0.0-rc3 (explain why)
> > >>>>>
> > >>>>> The vote will hold for 5 days and will end on May 17 2021 18:00 UTC
> > >>>>>
> > >>>>>
> > >>>
> >
> https://www.timeanddate.com/countdown/generic?iso=20210517T18&p0=0&font=cursive
> > >>>>> --
> > >>>>> Best wishes,
> > >>>>> Amelchev Nikita
> > >>>>>
> > >>>
> > >>>
> > >>> --
> > >>> Best wishes,
> > >>> Amelchev Nikita
> > >>>
> > >
> > >
> >
>
