Hi Atri, First and foremost, we need to clarify the API for this functionality. There are two options presented in the ticket, but no clear decision about which one should be used. I personally think that the original signature (the one in the ticket description) makes more sense, but it looks like you've implemented an alternative suggested in the comments. What was your motivation behind that?
As for where the method can be located, I'm OK if we add it directly to the IgniteSemaphore interface. -Val On Tue, Mar 9, 2021 at 8:22 AM Atri Sharma <a...@apache.org> wrote: > Gentle ping > > On Mon, 8 Mar 2021, 13:51 Atri Sharma, <a...@apache.org> wrote: > > > Hi All, > > > > I would like to start a discussion around IGNITE-2399. > > > > Background: The typical use of IgniteSemaphore consists of acquiring > > the semaphore, performing the task and releasing the semaphore. This > > JIRA proposes a new method which will accept a callable, acquire the > > semaphore, and return a future. Upon completion of the future, the > > semaphore is released. > > > > This API seems useful for an easy encapsulation of the described use > > case and does not cause an internal flux since all the changes are > > focused at the public API. > > > > WIP PR for the same: > > > > https://github.com/apache/ignite/pull/8820 > > > > Please share your thoughts and comments. > > > > -- > > Regards, > > > > Atri > > Apache Concerted > > >
