Got it. Didn't pay attention that those changes were in the readme.txt files.
Are you adjusting the docs on the website as well? I bet you were submitting a pull-request earlier. - Denis On Mon, Nov 16, 2020 at 6:31 PM Saikat Maitra <saikat.mai...@gmail.com> wrote: > Hi Denis, > > My thoughts are that these README.txt files will be published as part of > source releases for Ignite Extensions. > > Regards, > Saikat > > On Mon, Nov 16, 2020 at 5:28 PM Denis Magda <dma...@apache.org> wrote: > > > Hi Saikat, > > > > Please go ahead with the merge. Do we need to publish this for the Ignite > > 2.9 docs at some point? Guess, after the extensions are released under > > different names. > > > > - > > Denis > > > > > > On Sun, Nov 15, 2020 at 9:57 AM Saikat Maitra <saikat.mai...@gmail.com> > > wrote: > > > > > Hi, > > > > > > As discussed I have updated the PR > > > https://github.com/apache/ignite-extensions/pull/30 > > > > > > Please review and share your feedback. > > > > > > Regards, > > > Saikat > > > > > > On Mon, Nov 9, 2020 at 6:38 PM Saikat Maitra <saikat.mai...@gmail.com> > > > wrote: > > > > > > > Hi Nikolay, > > > > > > > > Thank you for reviewing the changes. I have made changes only in the > > > > README.txt file and updated the artifactId so that it matches with > > > pom.xml. > > > > > > > > I have also updated the version details in the PR so that it matches > > with > > > > our release version. > > > > > > > > https://github.com/apache/ignite-extensions/pull/30 > > > > > > > > With respect to naming convention I was thinking we would not be > > required > > > > to change the groupId and we will only change the artifactId similar > to > > > > spring-boot-autoconfigure-ext module. > > > > > > > > > > > > > > > > > > https://github.com/apache/ignite-extensions/blob/master/modules/spring-boot-autoconfigure-ext/pom.xml#L33 > > > > > > > > Please review and let me know your thoughts. > > > > > > > > Regards, > > > > Saikat > > > > > > > > > > > > > > > > > > > > On Mon, Nov 9, 2020 at 12:32 AM Nikolay Izhikov <nizhi...@apache.org > > > > > > wrote: > > > > > > > >> Hello, Saikat. > > > >> > > > >> As far as I can see you changed artifactId of the extensions not > only > > > >> docs. > > > >> > > > >> Do we have an agreement to name each extension as > > «{extension-name}-ext» > > > >> like «ignite-camel-ext» or similar? > > > >> We don’t have much extensions release, so maybe it will be better to > > > have > > > >> naming like > > > >> > > > >> groupId=org.apache.ignite.extensions > > > >> artifactId=ignite-camel > > > >> > > > >> What do you think? > > > >> > > > >> > > > >> > 9 нояб. 2020 г., в 05:36, Saikat Maitra <saikat.mai...@gmail.com> > > > >> написал(а): > > > >> > > > > >> > Hi, > > > >> > > > > >> > I have raised a PR for the following issue. > > > >> > > > > >> > Jira : https://issues.apache.org/jira/browse/IGNITE-12951 > > > >> > PR : https://github.com/apache/ignite-extensions/pull/30 > > > >> > > > > >> > This is an initial PR in Ignite Extensions repo. I will work on > > > another > > > >> PR > > > >> > in ignite repo for the remaining changes. > > > >> > > > > >> > Regards, > > > >> > Saikat > > > >> > > > >> > > > > > >
