Thank you Alexey Regards, Saikat
On Tue, Oct 13, 2020 at 6:38 AM Petr Ivanov <mr.wei...@gmail.com> wrote: > Thanks. Aleksey! > > > > On 13 Oct 2020, at 13:09, Alexey Goncharuk <alexey.goncha...@gmail.com> > wrote: > > > > Makes sense, > > > > I added a tag copy to match the released module name. > > > > вт, 13 окт. 2020 г. в 10:08, Petr Ivanov <mr.wei...@gmail.com>: > > > >> Keep it as a reference to what? > >> That tag will be confusing both users and developers because: > >> — there is no release of any extension with version 1.0, only 1.0.0 > >> — ignite-spring-boot can mean autoconfigure, thin-client-autoconfigure, > >> or both > >> > >> I think we should at least add new compliant tag to the same commit. > >> > >>> On 13 Oct 2020, at 05:26, Saikat Maitra <saikat.mai...@gmail.com> > wrote: > >>> > >>> Hi Petr, > >>> > >>> Since, we already released a version with the old tag I am thinking we > >> can > >>> keep it as reference and we can follow the new naming convention for > git > >>> tag from next release onwards. > >>> > >>> Regards, > >>> Saikat > >>> > >>> > >>> > >>> On Mon, Oct 12, 2020 at 1:42 AM Petr Ivanov <mr.wei...@gmail.com> > wrote: > >>> > >>>> Hi! > >>>> > >>>> > >>>> Yes., the git tag. > >>>> > >>>> The naming is good. thanks. > >>>> Can you also rename current one, please, or add new referring the old > >> with > >>>> agreed naming? > >>>> > >>>> > >>>>> On 10 Oct 2020, at 07:25, Saikat Maitra <saikat.mai...@gmail.com> > >> wrote: > >>>>> > >>>>> Hi Petr, > >>>>> > >>>>> Can you please share if the tag you are referring to is git release > tag > >>>> or > >>>>> changes required in some other file? > >>>>> > >>>>> If it is git release tag we can follow the naming convention as > >>>>> ignite-spring-boot-autoconfigure-ext-1.0.1 going forward. > >>>>> > >>>>> Regards, > >>>>> Saikat > >>>>> > >>>>> On Fri, Oct 9, 2020 at 5:11 AM Petr Ivanov <mr.wei...@gmail.com> > >> wrote: > >>>>> > >>>>>> > >>>>>> Hi, Igniters. > >>>>>> > >>>>>> > >>>>>> While working with ignite-extensions, I've faced some mismatch with > >>>> naming > >>>>>> of tag for extension: > >>>>>> > >>>>>> Artifact is 'ignite-spring-boot-autoconfigure-ext' > >>>>>> Module is 'spring-boot-autoconfigure-ext' > >>>>>> But tag is 'ignite-spring-boot-1.0.0' > >>>>>> > >>>>>> > >>>>>> Can we: > >>>>>> 1. match tag name with either module artifactID or maven name? > >>>>>> 2. replace current ignite-spring-boot-1.0.0 with the or add new > >> correct > >>>>>> one? > >>>> > >>>> > >> > >> > >
