Bojidar, Sincerely I never used an approach with attaching patch files. It would be great if you can open PR.
I suppose we should check with the Community whether a patch file approach is outdated and delete the section from the guide if it is. 2020-10-09 18:27 GMT+03:00, Bojidar Marinov <[email protected]>: > Hey Ivan, > > According to the "How to contribute" document, submitting patch files is a > valid alternative to github pull requests, refs > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file > . > If that information is outdated, I would happily open a pull request on > github instead. > > BRs, > Bojidar > > On Fri, Oct 9, 2020 at 6:20 PM Ivan Pavlukhin <[email protected]> wrote: > >> Bojidar, >> >> While my knowledge can be outdated, but in my time it was required to >> create a pull request in GitHub and launch a TC bot check against that >> PR manually. >> >> 2020-10-09 18:08 GMT+03:00, Bojidar Marinov <[email protected] >> >: >> > On Fri, Oct 9, 2020 at 5:15 PM Ivan Pavlukhin <[email protected]> >> wrote: >> > >> >> Hi Bojidar, >> >> >> >> Welcome to the Apache Ignite Community! >> >> >> >> Thanks! >> > >> >> I added your account to a contributors list, now you can assign >> >> tickets to yourself. Am I getting it right that your contribution is >> >> in .NET part? >> >> >> >> Indeed, it is a contribution to Ignite.NET. >> > >> > Also it could be helpful to get familiar with a contribution process >> >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute >> >> >> >> >> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot >> >> >> >> Went over them again and tagged the issue as patch-available. >> >> Hopefully, >> > teamcity would pick it up soon. :) >> > >> >> >> >> 2020-10-08 23:08 GMT+03:00, Божидар Маринов < >> [email protected] >> >> >: >> >> > Hello Ignite Community! >> >> > >> >> > My name is Bojidar Marinov. I have used Apache Ignite for the past >> >> > few >> >> > months, and I would like to contribute to it starting with issue >> >> > IGNITE-13563, my JIRA username being bojidar-bg. >> >> > I have already submitted a patch, and reviews would be welcome. >> >> > >> >> > BRs, >> >> > Bojidar >> >> > >> >> >> >> >> >> -- >> >> >> >> Best regards, >> >> Ivan Pavlukhin >> >> >> > >> >> >> -- >> >> Best regards, >> Ivan Pavlukhin >> > -- Best regards, Ivan Pavlukhin
