Maxim I suggested moving control.sh in a separate module, are we talking about the same thing?
02.06.2020, 16:15, "Maxim Muzafarov" <mmu...@apache.org>: > Folks, > > +1 > > However, AFAIK control.sh is the part of the ignite-core module with > zero dependencies from external resources. > Would it be better going the `control.sh` extensions-way? > > By the way, according to README.md [1] the picocli is already using by > the Apache Ignite, right? :-) > >> Picocli is used in the Apache Hadoop Ozone/HDDS command line tools, the >> Apache Hive benchmark CLI, has ** Apache [Ignite TensorFlow] **, and Apache >> Sling. > > [1] https://github.com/remkop/picocli/blame/master/README.md#L199 > > On Tue, 2 Jun 2020 at 16:09, Ivan Daschinsky <ivanda...@gmail.com> wrote: >> +1 But this is not only usability improvement, but also a huge code >> improvement. With picocli developers can add custom command without writing >> a lot of boilerplate and error prone code to do a trivial task >> of parsing CLI arguments. Cleaner code, less bugs also matter. >> >> вт, 2 июн. 2020 г. в 16:02, Sergey Antonov <antonovserge...@gmail.com>: >> >> > It would be a great usability improvement! >> > >> > +1 From me. >> > >> > вт, 2 июн. 2020 г. в 15:54, Zhenya Stanilovsky <arzamas...@mail.ru.invalid >> > >: >> > >> > > >> > > >> > > good catch ! it`s a little bit pain for now to working with it. >> > > >> > > >> > > >Hi, Igniters! >> > > > >> > > >At the moment to work with the control.sh we need to know exactly what >> > > the name of the command and its options are and so the user can often >> > make >> > > mistakes when using it. So I think it would be useful to do control.sh >> > more >> > > user-friendly by adding autocomplete as in modern command-line >> utilities. >> > > > >> > > >For this purpose, I suggest using framework [1] and to do this, take >> out >> > > control.sh together with its associated classes in a separate module >> such >> > > as "modules/control-utility". >> > > > >> > > >Comments, suggestions? >> > > > >> > > >[1] - https://picocli.info/ >> > > >> > > >> > > >> > > >> > >> > >> > >> > -- >> > BR, Sergey Antonov >> > >> >> -- >> Sincerely yours, Ivan Daschinskiy
