It seems reasonable to me. Also I would like to propose adding value of Ignition.KILL_EXIT_CODE into javadoc using @value javadoc tag.
Dev ops/admins/anyone who admins Ignite may want to know it's value without going to Java code. чт, 21 мая 2020 г. в 09:39, Zhenya Stanilovsky <arzamas...@mail.ru.invalid>: > > Thank you Sergey, as for me — very useful proposal huge +1 here. > > > >Четверг, 21 мая 2020, 0:51 +03:00 от Sergey Antonov < > antonovserge...@gmail.com>: > > > >I've created the Ignite ticket for this improvement [1]. > > > >[1] https://issues.apache.org/jira/browse/IGNITE-13047 > > > >чт, 21 мая 2020 г. в 00:46, Sergey Antonov < antonovserge...@gmail.com >: > > > >> Hello, Igniters! > >> > >> I'd like to discuss behaviour of Ignite process exit code if the node > was > >> stopped by failure handler [1][2]. At the moment ignite process returns > >> exit code 0 after the stop in all scenarios, except runtime halt by > >> StopNodeOrHaltFH [1]. In this case, the exit code will be 130 [3] > >> > >> My proposal: always finish Ignite process with code [3], if a node was > >> stopped by FH. It could be helpful for administration purposes, you can > >> distinguish normal node stop from node stop by FH on OS level. > >> > >> WDYT? > >> > >> [1] > >> > https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/failure/StopNodeOrHaltFailureHandler.html > >> > >> [2] > >> > https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/failure/StopNodeFailureHandler.html > >> > >> [3] > >> > https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/Ignition.html#KILL_EXIT_CODE > >> -- > >> BR, Sergey Antonov > >> > > > >-- > >BR, Sergey Antonov > > > > > >
