mstekl commented on a change in pull request #10:
URL: https://github.com/apache/ignite-website/pull/10#discussion_r417430944
##########
File path: index.html
##########
@@ -273,9 +278,9 @@ <h3>Applications Acceleration & Data Caching</h3>
using Ignite as an in-memory data grid.
</p>
- <a href="/use-cases/in-memory-data-grid.html"
class="btn btn-primary" title="In-Memory Data Grid"
+ <a href="/use-cases/in-memory-data-grid.html"
role="button" class="btn btn-primary" title="In-Memory Data Grid"
onclick="ga('send', 'event',
'apache_ignite_use_cases', 'homepage_click', 'data_grid');">
- Learn More</a>
+ Learn More About In-Memory Data Grid</a>
Review comment:
@dmagda, the purpose here was not to introduce a keyword, but to improve
usability. It is a good usability practice to use descriptive links and avoid
things like "click here", "read more", etc.
Here is some literature:
- https://accessibility.oregonstate.edu/descriptivelinks
-
https://developers.google.com/web/tools/lighthouse/audits/descriptive-link-text
Also on this particular case I even think having a longer text on those
buttons give more balance to the elements in terms of design. The button I
propose is not even as long as the titles on those boxes, and they introduce
more blue area that fills the empty space generated by the small "learn more"
buttons.
I don't know which reasons are you basing to consider these as "too much for
a button title", but please reconsider the merge based on this explanation.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
