Folks,
Are there any cases left which we need to discuss? Do you have any questions? I'm ready to provide all the details you need for the review. Who else what to take a look at my changes [1] [2]? [1] https://issues.apache.org/jira/browse/IGNITE-11073 [2] https://github.com/apache/ignite/pull/7607 On Fri, 24 Apr 2020 at 15:01, Maxim Muzafarov <mmu...@apache.org> wrote: > > Alexey, > > > I've addressed all your comments, please, take a look at the PR [1]. > Additional tests were added. > Additional comments with further steps were added. > > > [1] https://github.com/apache/ignite/pull/7607 > [2] https://issues.apache.org/jira/browse/IGNITE-11073 > > On Tue, 21 Apr 2020 at 09:53, Alexey Goncharuk > <alexey.goncha...@gmail.com> wrote: > > > > Maxim, > > > > I've left my comments in the PR. > > > > пн, 20 апр. 2020 г. в 12:52, Maxim Muzafarov <mmu...@apache.org>: > > > > > Alex P, > > > Thank you for the great sophisticated review. > > > > > > > > > Alexey G, > > > Will you take a look at my changes[1]? > > > The fresh TC.Bot visa attached. > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11073 > > > > > > On Mon, 20 Apr 2020 at 11:54, Alex Plehanov <plehanov.a...@gmail.com> > > > wrote: > > > > > > > > Maxim, I've reviewed your PR and it looks good to me. Good job! > > > > > > > > пт, 10 апр. 2020 г. в 19:43, Alexey Goncharuk < > > > alexey.goncha...@gmail.com>: > > > > > > > > > Maxim, > > > > > > > > > > Thanks for raising this PR. I will do a review during next week. > > > > > > > > > > --AG > > > > > > > >
