Maxim, It's a good idea! Please don't forget to update out code style guidelines too.
Thank you for keeping the code cleaner! пт, 24 апр. 2020 г. в 19:49, Maxim Muzafarov <mmu...@apache.org>: > Igniters, > > > It is not directly mentioned through the Apache Ignite Coding > Guidelines [1] about naming the `static final` class fields using only > upper-case letters. I'd like to suggest to fill this gap. > > > Constants should all be upper-case. > But what exactly is `constant` means?! I'd suggest applying this rule > to all class fields with `static final` modifiers without any clauses. > (check Java Naming convention [2] paragraph 3.3). > > > I've prepared PR [3] with capitalizing letters on all of the constant > names simultaneously with supporting the standard ConstantName > checkstyle [4] rule. > > Can we proceed with this change? > WDYT? > > > [1] > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Naming > [2] > https://web.archive.org/web/20120911192801/developers.sun.com/sunstudio/products/archive/whitepapers/java-style.pdf > [3] https://github.com/apache/ignite/pull/7662 > [4] https://issues.apache.org/jira/browse/IGNITE-12888 > -- BR, Sergey Antonov
