Hi Saikat, My thinking is that the removal should take place with the next minor release 2.9. I wouldn't do this in maintenance versions such as 2.8.x.
Btw, how about creating a page for Ignite extensions on the website that will be placed under "Features" menu? Would you be interested in that? - Denis On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <saikat.mai...@gmail.com> wrote: > Hello, > > I wanted to discuss on merge process for PR in ignite modules when we are > migrating extensions. > > I have created these 2 PR for ZeroMQ to migrate from ignite to ignite > extension repo and also to remove ZeroMQ from ignite repo. > > > https://github.com/apache/ignite-extensions/pull/5 > https://github.com/apache/ignite/pull/7240 > > Both the PR are reviewed and in approved state and I have merged the > changes for ignite-extensions. > > I wanted to discuss if this is right time to merge removal of ZeroMQ module > PR from ignite repo or shall I wait for initial release of > ignite-extensions - ZeroMQ module? > > Regards, > Saikat > > > > > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <saikat.mai...@gmail.com> > wrote: > > > Hi Mikhail, > > > > Thank you for help in review. I have merged the changes. > > > > Regards, > > Saikat > > > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <saikat.mai...@gmail.com> > > wrote: > > > >> Hi Ilya, Mikhail > >> > >> I have updated the PR as per review comments. > >> > >> Please take a look and share your feedback. > >> > >> PR https://github.com/apache/ignite-extensions/pull/5 > >> https://github.com/apache/ignite/pull/7240 > >> > >> Regards, > >> Saikat > >> > >> > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <saikat.mai...@gmail.com> > >> wrote: > >> > >>> Hello, > >>> > >>> Can someone please help in review for these following PRs. I have > >>> received approval for release process from Alexey and would need a code > >>> review approval for following PR. > >>> > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358 > >>> > >>> PR https://github.com/apache/ignite-extensions/pull/5 > >>> https://github.com/apache/ignite/pull/7240 > >>> > >>> > >>> Regards, > >>> Saikat > >>> > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <saikat.mai...@gmail.com > > > >>> wrote: > >>> > >>>> Yes sure, thank you Denis > >>>> > >>>> Regards, > >>>> Saikat > >>>> > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dma...@apache.org> > wrote: > >>>> > >>>>> Hi Saikat, > >>>>> > >>>>> Let's wait while Alex Goncharuk checks a similar PR here: > >>>>> > >>>>> > http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html > >>>>> > >>>>> After that, we can return to this pending pull request. > >>>>> > >>>>> - > >>>>> Denis > >>>>> > >>>>> > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra < > >>>>> saikat.mai...@gmail.com> > >>>>> wrote: > >>>>> > >>>>> > Hi, > >>>>> > > >>>>> > I have raised PR for Ignite zeromq migration to Ignite Extensions > >>>>> repo. > >>>>> > > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358 > >>>>> > > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5 > >>>>> > https://github.com/apache/ignite/pull/7240 > >>>>> > > >>>>> > Please review and share feedback. > >>>>> > > >>>>> > This is part of our Modularization effort for Streamer modules > >>>>> > > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355 > >>>>> > > >>>>> > Regards, > >>>>> > Saikat > >>>>> > > >>>>> > >>>> >
