Hello Taras, I think this is the right way. I agree with Pavel's comment. It would be nice to provide a list of properties that can be changed at runtime and remove the word “Initial” from the class name.
Thanks, S. пн, 23 мар. 2020 г. в 16:54, Pavel Tupitsyn <ptupit...@apache.org>: > Hi Taras, > > I support the idea, it brings some order to the IgniteConfiguration. > > However, I have strong objections to `Initial` prefix: > > many parameters may be changed in runtime > This applies to many other config properties, but we don't name them > `Initial` > > Let's just make it SqlConfiguration. > > On Mon, Mar 23, 2020 at 1:04 PM Taras Ledkov <tled...@gridgain.com> wrote: > > > Hi, Igniters. > > > > I propose to introduce separate configuration class for SQL > configuration. > > e.g. SqlInitailConfiguration. > > > > Now we have several SQL parameters: > > - sqlSchemas; > > - defaultQueryTimeout; > > - longQueryWarningTimeout; > > - sqlQueryHistorySize; > > > > are placed at the IgniteConfiguration. > > I propose to deprecate the SQL properties in the IgniteConfiguration and > > redirect the calls to child configuration object of > > SqlInitailConfiguration. > > > > We are going to add several additional parameters in the nearest future. > > I guess separate configuration is better than many plain SQL parameters > > at the root IgniteConfiguration. > > > > I insist on the configuration be called 'Initial' because many > > parameters may be changed in runtime > > (e.g. longQueryWarningTimeout by JMX, set of schemas by creating caches > > etc). > > > > I've created PR [1] that contains proposal changes. The patch is not > > final clean. > > I think PR may be useful to demonstrate the proposal. > > > > Please let me know your opinion. > > > > [1]. https://github.com/apache/ignite/pull/7559 > > > > > > -- > > Taras Ledkov > > Mail-To: tled...@gridgain.com > > > > >
