Hi,
I believe, we definitely should not ignore this.
Alexey, you are the author of this code. What do you think?
Best Regards,
Igor
On Thu, Feb 27, 2020 at 3:56 PM Aleksandr Shapkin <lexw...@gmail.com> wrote:
> Hello!
>
>
>
> I just noticed that the Java thin client throws the following internal
> exceptions:
>
> ClientProtocolError
>
> ClientError
>
>
>
> Since the classes are not public, there is no way to catch them properly in
> user code.
>
> Consider the recent changes, introduced by IGNITE-9410:
>
>
>
> throw new ClientProtocolError(String.format("Transactions have not
> supported by the server's " +
>
> "protocol version %s, required version %s",
> req.clientChannel().serverVersion(), V1_5_0));
>
>
>
> The code above correctly verifies the server version against the current
> client and throws an exception
>
> In case of an outdated server. The only way to catch it in user code is by
> RuntimeException
>
> that feels too broad to use.
>
>
>
> I’d like to discuss what’d be the best option to handle this scenario:
>
> - Should we make the ClientError public?
>
> - Should we introduce a new public error for every particular
> exception?
>
> - Just ignore this?
>
>
>
> Thoughts?
>
> --
> Alex.
>
