Thanks for answer, Andrey. I'm confused about your first comment. Does it mean, that the only thing I can do is to create new annotation? Because, as you said, I must leave unchanged all related to old annotations functionality. So, I can't change implementation of *getDescription / getParameterName (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from* IgniteStandardMXBean* class, and replace current annotations with new one.
вт, 4 февр. 2020 г. в 14:28, Andrey Gura <ag...@apache.org>: > Hi, Lev! > > I think you understand task correctly. > > A couple of comments: > > - Existing annotations and related functionality must not be deleted > because it is part of public API and we committed to have stable API > between major releases. > - I would suggest introduce @MXBeanParameter annotation instead of > @MXBeanParameterInformation. Just shorten name. > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <dma...@apache.org> wrote: > > > > Nikolay, Andrey, > > > > Would you be the best committers to help out here? You are already > deeply involved in metrics development and can quickly suggest Lev how to > proceed with this task. > > > > - > > Denis > > > > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <lev.kiselev.1...@gmail.com> > wrote: > >> > >> Hello everyone, I have question about following task: > >> [https://issues.apache.org/jira/browse/IGNITE-10698] > >> Solution proposed in task description is seem to be logical. > >> So, I need to every replace @MXBeanParametersNames and > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with > something > >> like: > >> void methodName(@MXBeanParameterInformation(name = "name", description = > >> "description") firstParameter, ...) {}. > >> And, of course, need to change processing logic at > >> getParameterName/getDescription methods from IgniteStandardMXBean. > >> Do I understand correctly what needs to be done? >
