Zhenya Stanilovsky, Enabling all events has benefit of additional test coverage and disabling some of them may break tests in unpredictable manner. I would first check TC run time gain before applying the change. Please create a PR and compare run durations with and without change. Showing here results would be good.
чт, 29 авг. 2019 г. в 13:11, Zhenya Stanilovsky <arzamas...@mail.ru.invalid >: > Igniters, after dummy perf vs flamegraph tests i found all events are > enabled on GridAbstractTest: > cfg.setIncludeEventTypes(EventType.EVTS_ALL); ticket [1] with flamegraph > attached show 7-8% spending in GridCacheEventManager::addEvent, i suppose > this extra functional for all inheritors. > > If no objections i plan to set this events only for really requiring tests. > > thanks! > > [1] https://issues.apache.org/jira/browse/IGNITE-12122 > > -- > Zhenya Stanilovsky -- Best regards, Alexei Scherbakov
