Nikolay, +1. I'd add my 50 cents. There should no TODOs without any ticket link, otherwise such TODOs will never be fixed.
On Fri, Jun 7, 2019 at 4:23 PM Andrey Gura <ag...@apache.org> wrote: > Big +1 from me. > Make code base clean and clear. > > On Fri, Jun 7, 2019 at 3:26 PM Nikolay Izhikov <nizhi...@apache.org> > wrote: > > > > Hello, Igniters. > > > > Please, pay attention to commits quality. > > > > 1. Please, writer Javadocs. > > 2. Please, make the new lines according to code style. > > > > Issues like [1] has to be fixed *BEFORE* commit. > > > > > > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java#L45 > > > -- Best regards, Andrey V. Mashenkov
