Petr. Scala profile already exists in ignite-examples. But is wan't used in "Build Ignite"
https://github.com/apache/ignite/blob/master/examples/pom.xml#L174 В Чт, 06/06/2019 в 14:56 +0300, Petr Ivanov пишет: > Still cannot find addition of `scala` profile in that PR. > > Am I missing something? > > > On 5 Jun 2019, at 15:10, Maxim Muzafarov <maxmu...@gmail.com> wrote: > > > > Folks, > > > > I've checked PR [1] and it seems to me it fixes the main issue with a > > spark examples. > > After adding `scala` profile the [Example] Suite in the master branch > > starts to fail - [2] and it works fine in the PR branch [3] (Javadocs > > also compiles). > > > > Not sure, but adding this profile also fixes the [Check Code Style] > > Suite too which is failing [4] in the master branch on compile > > `ignite-scalar` module. I will investigate it more shortly. > > > > [1] https://github.com/apache/ignite/pull/6587 > > [2] > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Examples&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > > [3] > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Examples&branch_IgniteTests24Java8=pull%2F6587%2Fhead&tab=buildTypeStatusDiv > > [4] > > https://ci.ignite.apache.org/viewLog.html?buildId=4046113&buildTypeId=IgniteTests24Java8_CheckCodeStyle > > > > > > On Wed, 5 Jun 2019 at 12:35, Petr Ivanov <mr.wei...@gmail.com> wrote: > > > > > > I've added 'scala' profile to ~Build Apache Ignite~. > > > Can you check please that everything is OK now? > > > > > > > On 5 Jun 2019, at 12:16, Nikolay Izhikov <nizhi...@apache.org> wrote: > > > > > > > > Petr. > > > > > > > > Current PR solves the following issue: "Data Frame examples crashes in > > > > master". > > > > > > > > We need to solve one more issue: > > > > > > > > "Data Frame examples not tested on TC" - this require "scala" profile > > > > in "Build Ignite" suite. > > > > > > > > > > > > В Ср, 05/06/2019 в 12:05 +0300, Petr Ivanov пишет: > > > > > > On 5 Jun 2019, at 11:49, Nikolay Izhikov <nizhi...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > 1. Why does your PR show only single file changed? > > > > > > > > > > > > Because this change fix the issue described in the ticket [1] > > > > > > > > > > So changes in intermediate commits were reverted in branch? > > > > > > > > > > > > > > > > > > > > > > > 2. Can you describe the problem once more, please? Is it about > > > > > > > > > > > > :ignite-examples module not being build in ~Build Apache Ignite~ ? > > > > > > > > > > > > Spark examples activated only if `scala` profile enabled. > > > > > > There is no `scala` profile in "~Build Apache Ignite~", only > > > > > > `all-scala`. > > > > > > > > > > Let's add 'scala' profile into build. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11881 > > > > > > > > > > > > ср, 5 июн. 2019 г. в 10:59, Petr Ivanov <mr.wei...@gmail.com>: > > > > > > > > > > > > > Nikolay, > > > > > > > > > > > > > > > > > > > > > 1. Why does your PR show only single file changed? > > > > > > > 2. Can you describe the problem once more, please? Is it about > > > > > > > :ignite-examples module not being build in ~Build Apache Ignite~ ? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 4 Jun 2019, at 20:34, Nikolay Izhikov <nizhi...@apache.org> > > > > > > > > wrote: > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > Root of the issue is in our maven profiles hierarchy. > > > > > > > > > > > > > > > > "Build Ignite" suite on TC activate 'all-scala' and examples > > > > > > > > module have > > > > > > > > > > > > > > only 'scala' profile. > > > > > > > > To reduce copy-pase I added 'scala' profile of examples module > > > > > > > > > > > > > > activation based on system property 'scala-examples'. > > > > > > > > > > > > > > > > So, for now my PR [1] fixes both issues with examples module: > > > > > > > > > > > > > > > > 1. Unnecessary dependecies that leads to Spark examples crash. > > > > > > > > 2. Spark examples not tested on TC. > > > > > > > > > > > > > > > > After merge of PR [1] we should add this property to "Build > > > > > > > > Ignite" > > > > > > > > > > > > > > suite. > > > > > > > > > > > > > > > > Is there any objections? > > > > > > > > > > > > > > > > [1] https://github.com/apache/ignite/pull/6587 > > > > > > > > > > > > > > > > [2] > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4041670&buildTypeId=IgniteTests24Java8_Examples&tab=testsInfo&branch_IgniteTests24Java8=pull%2F6587%2Fhead > > > > > > > > > > > > > > > > > > > > > > > > В Вт, 04/06/2019 в 16:56 +0300, Nikolay Izhikov пишет: > > > > > > > > > I moved jackson dependencies to maven-javadoc-plugin > > > > > > > > > additional > > > > > > > > > > > > > > dependencies. > > > > > > > > > Seems, it solves both issues: Data Frame examples and javadoc > > > > > > > > > > > > > > generation. > > > > > > > > > > > > > > > > > > But, Data Frame examples still doesn't shows in tc log. > > > > > > > > > > > > > > > > > > Will investigate it, shortly. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4039945&tab=queuedBuildOverviewTab > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4039943&;;;;; > > > > > > > > > > > > > > > > > > В Вт, 04/06/2019 в 15:45 +0300, Павлухин Иван пишет: > > > > > > > > > > Would be great if it is possible. > > > > > > > > > > > > > > > > > > > > вт, 4 июн. 2019 г. в 15:43, Nikolay Izhikov > > > > > > > > > > <nizhi...@apache.org>: > > > > > > > > > > > > > > > > > > > > > > I used to think it's forbidden to use direct version in > > > > > > > > > > > pom.xml. > > > > > > > > > > > We should keep all versions in parent pom. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > В Вт, 04/06/2019 в 15:36 +0300, Павлухин Иван пишет: > > > > > > > > > > > > Nikolay, > > > > > > > > > > > > > > > > > > > > > > > > It was already observed that removal of jackson > > > > > > > > > > > > dependencies from > > > > > > > > > > > > examples module would lead to a Javadoc build job > > > > > > > > > > > > failure (for > > > > > > > > > > > > examples module). One way to fix it is changing jackson > > > > > > > > > > > > dependency > > > > > > > > > > > > versions: > > > > > > > > > > > > <dependency> > > > > > > > > > > > > <groupId>com.fasterxml.jackson.core</groupId> > > > > > > > > > > > > <artifactId>jackson-core</artifactId> > > > > > > > > > > > > <version>2.6.7</version> > > > > > > > > > > > > </dependency> > > > > > > > > > > > > > > > > > > > > > > > > <dependency> > > > > > > > > > > > > <groupId>com.fasterxml.jackson.core</groupId> > > > > > > > > > > > > <artifactId>jackson-databind</artifactId> > > > > > > > > > > > > <version>2.6.7</version> > > > > > > > > > > > > </dependency> > > > > > > > > > > > > > > > > > > > > > > > > <dependency> > > > > > > > > > > > > <groupId>com.fasterxml.jackson.core</groupId> > > > > > > > > > > > > <artifactId>jackson-annotations</artifactId> > > > > > > > > > > > > <version>2.6.7</version> > > > > > > > > > > > > </dependency> > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 июн. 2019 г. в 14:57, Nikolay Izhikov > > > > > > > > > > > > <nizhi...@apache.org>: > > > > > > > > > > > > > > > > > > > > > > > > > > Igniters > > > > > > > > > > > > > > > > > > > > > > > > > > I've found the root issue. > > > > > > > > > > > > > > > > > > > > > > > > > > jackson dependency was added in IGNITE-10803 and > > > > > > > > > > > > > that's brokes > > > > > > > > > > > > > > Spark Examples. > > > > > > > > > > > > > > > > > > > > > > > > > > Alex, Yury, please, clarify, do we really need this > > > > > > > > > > > > > dependencies? > > > > > > > > > > > > > > > > > > > > > > > > > > В Вт, 04/06/2019 в 11:42 +0300, Павлухин Иван пишет: > > > > > > > > > > > > > > But -Pscala is already activated. But it seems that > > > > > > > > > > > > > > a build job in > > > > > > > > > > > > > > question does not compile classes and retrieves a > > > > > > > > > > > > > > compiled package > > > > > > > > > > > > > > from ~Build Apache Ignite~ job. Need to check if > > > > > > > > > > > > > > spark examples are > > > > > > > > > > > > > > present. > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 июн. 2019 г. в 09:52, Павлухин Иван > > > > > > > > > > > > > > <vololo...@gmail.com>: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Nikolay, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > It looks like that profile -Pscala should be > > > > > > > > > > > > > > > activated to run > > > > > > > > > > > > > > > IgniteExamplesSparkSelfTestSuite. I was able to > > > > > > > > > > > > > > > start that suite > > > > > > > > > > > > > > > execution on my machine but it failed during > > > > > > > > > > > > > > > execution. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 июн. 2019 г. в 03:08, Denis Magda > > > > > > > > > > > > > > > <dma...@apache.org>: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hey Peter, Anton, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Are any of you able to help Nickolay with [1]? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > - > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jun 3, 2019 at 6:17 AM Nikolay Izhikov < > > > > > > > > > > > > > > nizhi...@apache.org> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > We have several issues with Examples suite on > > > > > > > > > > > > > > > > > TC > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 1. IgniteExamplesSparkSelfTestSuite seems > > > > > > > > > > > > > > > > > configure, bu not > > > > > > > > > > > > > > runs on suite > > > > > > > > > > > > > > > > > execution. [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2. Spark Data Frame examples doesn't work in > > > > > > > > > > > > > > > > > master. Seems some > > > > > > > > > > > > > > classpath > > > > > > > > > > > > > > > > > issues [2] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I will resolve issue #2. > > > > > > > > > > > > > > > > > Can anyone help me with #1? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4027327&buildTypeId=IgniteTests24Java8_Examples&tab=buildParameters > > > > > > > > > > > > > > > > > [2] > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-11881 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > Ivan Pavlukhin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
signature.asc
Description: This is a digitally signed message part
