Hi, Ilya! It looks like Spring *ThreadPoolTaskScheduler* is bounded to JDK's *ScheduledThreadPoolExecutor*, so to launch scheduled tasks on public pool we need provide *ScheduledThreadPoolExecutor* for Public pool. Currently I see we create Public pool executor as *IgniteThreadPoolExecutor* and it extends *ThreadPoolExecutor*. It seems we can easily introduce *IgniteScheduledThreadPoolExecutor* and extend it from *ScheduledThreadPoolExecutor* for public pool. How do you like it?
Your idea about delegating tasks from Spring 1-threaded pool to Public pool looks also workable. Best regards, Sergey Kosarev. вт, 25 дек. 2018 г. в 18:19, Ilya Kasnacheev <[email protected]>: > Hello! > > I have started reviewing your pull request. > I will expect that scheduled tasks are executed on Public pool. Is it > possible that tasks are launched on Public pool? If Spring Scheduler > insists on its own thread pool, we can have single-thread pool which will > execute put of tasks to public pool and immediately return. Is it possible > to do that? > > Regards, > -- > Ilya Kasnacheev > > > вт, 25 дек. 2018 г. в 17:46, Alexey Kuznetsov <[email protected]>: > > > Hi, Sergey! > > > > I think we should keep compatibility as much as possible for Ignite 2.x. > > And we can do breaking changes in Ignite 3.x > > > > What do you think? > > > > > > On Mon, Dec 24, 2018 at 11:58 PM Sergey <[email protected]> wrote: > > > > > HI, Igniters! > > > > > > I've updated and rebased implementation to master branch and made some > > > fixes. > > > Also I have a question regarding current implementation. > > > > > > As I found Cron4J source code this implementation checks schedule every > > > minute (seconds not supported) but spawns a thread for every task which > > > scheduling pattern matches the current time. There no any limits to the > > > number of tasks launched silmultaneously. > > > > > > New implementation is based on > > > org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler > > > with its default parameters currently, i.e thread pool size is 1. > > > > > > Could you advise me, do we need to add some system property or > introduce > > > some attribute to IgniteConfiguration to configure Scheduler thread > pool > > > size? And what should be default value? > > > > > > > > > Best regards, > > > Sergey Kosarev. > > > > > > > > > чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov <[email protected]>: > > > > > > > Hi Anton, > > > > > > > > Thank you for joining and review. > > > > I hope all proposals will be applied. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > пт, 4 мая 2018 г. в 16:04, Anton Vinogradov <[email protected]>: > > > > > > > > > Folks, > > > > > > > > > > How can it be at PATCH AVAILABLE since *none* of my latest comments > > > (made > > > > > Feb 8) are resolved at Upsource? > > > > > Changed state to IP. > > > > > > > > > > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov <[email protected] > >: > > > > > > > > > > > Hi Andrey, > > > > > > > > > > > > Could you please pick up review? > > > > > > > > > > > > Sincerely, > > > > > > Dmitriy Pavlov > > > > > > > > > > > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan < > > > [email protected] > > > > >: > > > > > > > > > > > > > Dmitriy, who is a good candidate within the community to review > > > this > > > > > > > ticket? > > > > > > > > > > > > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov < > > > > [email protected]> > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Igniters, > > > > > > > > > > > > > > > > it seems ticket > > > https://issues.apache.org/jira/browse/IGNITE-5565 > > > > is > > > > > > > still > > > > > > > > in PA state. What are our next steps? > > > > > > > > > > > > > > > > Who did review of this patch? > > > > > > > > > > > > > > > > Sincerely, > > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda <[email protected]>: > > > > > > > > > > > > > > > > > Yakov, > > > > > > > > > > > > > > > > > > No, the mentioned discussion didn’t turn into a JIRA > ticket. > > > > > > > > > > > > > > > > > > Alex K., please follow to some thoughts from there and wrap > > > them > > > > up > > > > > > in > > > > > > > a > > > > > > > > > form of the ticket. > > > > > > > > > > > > > > > > > > — > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov < > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Guys, I remember we discussed this some time ago. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://apache-ignite-developers.2346864.n4.nabble. > > > > > > > > com/Tasks-Scheduling-and-Chaining-td14293.html > > > > > > > > > > > > > > > > > > > > Denis, do you have any ticket or SoW? > > > > > > > > > > > > > > > > > > > > --Yakov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Alexey Kuznetsov > > >
