Hi Ivan, I've merged your PR and added permissions to the wiki, please check.
I still feel we need to migrate code to ASF repo. I will try to do something for that. Sincerely, Dmitriy Pavlov пн, 17 дек. 2018 г. в 13:44, Павлухин Иван <vololo...@gmail.com>: > Hi, > > I did some investigation regarding scala support and it seems that > version used today (3.0.0) was build without scala support. If nobody > minds I suggest to build a new version without scala as well. > > Also there is a thing that bothers me a little. IDEA throws exception > in log when a name is abbreviated by plugin (see at the very bottom of > this message). I build old version on my machine as well and received > the same. It seems that it was there before my changes. Or it might be > somehow related to version of IDEA which I used to build the plugin. > > 2018-12-17 13:35:10,849 [ 21351] ERROR - > oring.BaseRefactoringProcessor - Refactorings should not be started > inside write action > because they start progress inside and any read action from the > progress task would cause the deadlock > java.lang.Exception > at > com.intellij.refactoring.BaseRefactoringProcessor.run(BaseRefactoringProcessor.java:560) > at > com.intellij.refactoring.RefactoringImpl.run(RefactoringImpl.java:73) > at > org.apache.ignite.idea.inspection.abbrev.IgniteAbbreviationInspection$RenameToFix.rename(IgniteAbbreviationInspection.java:163) > at > org.apache.ignite.idea.inspection.abbrev.IgniteAbbreviationInspection$RenameToFix.applyFix(IgniteAbbreviationInspection.java:148) > at > org.apache.ignite.idea.inspection.abbrev.IgniteAbbreviationInspection$RenameToFix.applyFix(IgniteAbbreviationInspection.java:121) > at > com.intellij.codeInspection.ex.QuickFixWrapper.invoke(QuickFixWrapper.java:75) > at > com.intellij.codeInsight.intention.impl.IntentionActionWithTextCaching$MyIntentionAction.invoke(IntentionActionWithTextCaching.java:173) > at > com.intellij.codeInsight.intention.impl.ShowIntentionActionsHandler.lambda$invokeIntention$3(ShowIntentionActionsHandler.java:202) > at > com.intellij.openapi.application.WriteAction.run(WriteAction.java:105) > at > com.intellij.codeInsight.intention.impl.ShowIntentionActionsHandler.invokeIntention(ShowIntentionActionsHandler.java:204) > at > com.intellij.codeInsight.intention.impl.ShowIntentionActionsHandler.lambda$null$1(ShowIntentionActionsHandler.java:179) > at > com.intellij.openapi.application.TransactionGuardImpl.runSyncTransaction(TransactionGuardImpl.java:88) > at > com.intellij.openapi.application.TransactionGuardImpl.submitTransactionAndWait(TransactionGuardImpl.java:153) > at > com.intellij.codeInsight.intention.impl.ShowIntentionActionsHandler.lambda$chooseActionAndInvoke$2(ShowIntentionActionsHandler.java:178) > at > com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:139) > at > com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:97) > at > com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:87) > at > com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:73) > at > com.intellij.codeInsight.intention.impl.ShowIntentionActionsHandler.chooseActionAndInvoke(ShowIntentionActionsHandler.java:177) > at > com.intellij.codeInsight.intention.impl.IntentionListStep.lambda$applyAction$0(IntentionListStep.java:118) > at > com.intellij.openapi.application.TransactionGuardImpl.performUserActivity(TransactionGuardImpl.java:195) > at > com.intellij.ui.popup.AbstractPopup.lambda$dispose$8(AbstractPopup.java:1417) > at com.intellij.util.ui.UIUtil.invokeLaterIfNeeded(UIUtil.java:3097) > at > com.intellij.ide.IdeEventQueue.ifFocusEventsInTheQueue(IdeEventQueue.java:183) > at > com.intellij.ide.IdeEventQueue.executeWhenAllFocusEventsLeftTheQueue(IdeEventQueue.java:132) > at > com.intellij.openapi.wm.impl.FocusManagerImpl.doWhenFocusSettlesDown(FocusManagerImpl.java:190) > at > com.intellij.openapi.wm.impl.IdeFocusManagerImpl.doWhenFocusSettlesDown(IdeFocusManagerImpl.java:58) > at com.intellij.ui.popup.AbstractPopup.dispose(AbstractPopup.java:1411) > at com.intellij.ui.popup.WizardPopup.dispose(WizardPopup.java:160) > at > com.intellij.ui.popup.list.ListPopupImpl.dispose(ListPopupImpl.java:307) > at com.intellij.openapi.util.Disposer$1.execute(Disposer.java:48) > at com.intellij.openapi.util.Disposer$1.execute(Disposer.java:44) > at > com.intellij.openapi.util.objectTree.ObjectNode$1.execute(ObjectNode.java:138) > at > com.intellij.openapi.util.objectTree.ObjectNode$1.execute(ObjectNode.java:107) > at > com.intellij.openapi.util.objectTree.ObjectTree.executeActionWithRecursiveGuard(ObjectTree.java:182) > at > com.intellij.openapi.util.objectTree.ObjectNode.execute(ObjectNode.java:107) > at > com.intellij.openapi.util.objectTree.ObjectTree.executeAll(ObjectTree.java:151) > at com.intellij.openapi.util.Disposer.dispose(Disposer.java:129) > at com.intellij.openapi.util.Disposer.dispose(Disposer.java:125) > at > com.intellij.ui.popup.WizardPopup.disposeAllParents(WizardPopup.java:263) > at > com.intellij.ui.popup.list.ListPopupImpl.handleNextStep(ListPopupImpl.java:442) > at > com.intellij.ui.popup.list.ListPopupImpl._handleSelect(ListPopupImpl.java:396) > at > com.intellij.ui.popup.list.ListPopupImpl.handleSelect(ListPopupImpl.java:337) > at > com.intellij.ui.popup.list.ListPopupImpl$1.actionPerformed(ListPopupImpl.java:250) > at > com.intellij.ui.popup.WizardPopup.proceedKeyEvent(WizardPopup.java:378) > at com.intellij.ui.popup.WizardPopup.dispatch(WizardPopup.java:358) > at > com.intellij.ui.popup.PopupDispatcher.dispatchKeyEvent(PopupDispatcher.java:126) > at > com.intellij.ui.popup.PopupDispatcher.dispatch(PopupDispatcher.java:160) > at com.intellij.ide.IdePopupManager.dispatch(IdePopupManager.java:86) > at > com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:673) > at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:382) > at > java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) > at > java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) > at > java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) > at > java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) > at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) > at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) > сб, 15 дек. 2018 г. в 17:37, Павлухин Иван <vololo...@gmail.com>: > > > > Vyacheslav, > > > > > PR looks good to me in general, but I've noticed a possible typo in > > > the PR and Wiki: > > > 'lable' -> 'label' > > > > Good catch! I updated a PR [1]. Could someone fix it on wiki or give > > me rights to edit wiki? (my login is "pavlukhin") > > > > > Also, according to the wiki, the following rules should be added: > > > 'topologyVersion' -> 'topVer' > > > 'regularExpression' -> 'regex' > > > > Actually, the plugin operates with tokens which are determined > > assuming camel-case naming style. So, "topologyVersion" will be split > > to "topology" and "Version" and converted to "topVer" by transforming > > each token. But we cannot do so with "regularExpression" because there > > is no rules for "regular" and "expression". And even if we had such it > > would produce "regEx". Adding a rule "regularExpression=regex" to > > abbreviation.properties does not lead to desired effect. > > > > [1] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2 > > > > 2018-12-15 12:13 GMT+03:00, Vyacheslav Daradur <daradu...@gmail.com>: > > > Ivan, thank you! > > > > > > PR looks good to me in general, but I've noticed a possible typo in > > > the PR and Wiki: > > > 'lable' -> 'label' > > > > > > Also, according to the wiki, the following rules should be added: > > > 'topologyVersion' -> 'topVer' > > > 'regularExpression' -> 'regex' > > > > > > Am I miss something? > > > > > > On Sat, Dec 15, 2018 at 11:17 AM Павлухин Иван <vololo...@gmail.com> > wrote: > > >> > > >> Hi Dmitriy, Vyacheslav, > > >> > > >> I created a ticket [1] and PR [2] for updating a list of abbreviations > > >> used by the plugin. The changes in the plugin itself looks trivial. > > >> But some extra build and publish steps are required (see the ticket). > > >> Also if I understand it correctly plugin should be build with scala > > >> support. I will need some time to ensure that I can build it properly. > > >> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-10704 > > >> [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2 > > >> > > >> 2018-11-02 21:38 GMT+03:00, Dmitriy Pavlov <dpavlov....@gmail.com>: > > >> > Hi Vyacheslav, > > >> > > > >> > I'm sorry I almost gave up with this donation > > >> > > > >> > > http://apache-ignite-developers.2346864.n4.nabble.com/Re-Place-Ignite-Abbrev-Plugin-to-ASF-Ignite-supplementary-git-repo-tp32745p32764.html > > >> > because > > >> > we need someone to sign a software grant agreement, but there were > > >> > several > > >> > people who contributed to the plugin. > > >> > > > >> > Some of the authors are not active contributors anymore. So I've > stuck > > >> > with > > >> > finding a way how to donate. > > >> > > > >> > Sincerely, > > >> > Dmitriy Pavlov > > >> > > > >> > пт, 2 нояб. 2018 г. в 21:24, Vyacheslav Daradur < > daradu...@gmail.com>: > > >> > > > >> >> I've double checked, we are really able to use IDEA inspection's to > > >> >> inspect abbreviations by inspection's structure search and replace > > >> >> templates. > > >> >> It rather not intuitive and requires complex regex patterns. > > >> >> > > >> >> Also, at first sight, it shouldn't be difficult to work with the > > >> >> project's local properties from the plugin. > > >> >> > > >> >> On Fri, Nov 2, 2018 at 2:32 PM Vyacheslav Daradur > > >> >> <daradu...@gmail.com> > > >> >> wrote: > > >> >> > > > >> >> > I like your idea about auto updates. > > >> >> > > > >> >> > In this case, abbr-plugin should be improved to check and > download > > >> >> > updates from external URI or local repo. > > >> >> > Looks like it could be implemented using Intellij's SDK virtual > file > > >> >> > [1]. > > >> >> > > > >> >> > But as I can see that abbreviations list update is the very rare > > >> >> > case, > > >> >> > therefore I'm not sure that we really need to do it. > > >> >> > > > >> >> > Also, I have another idea we can try to use IDEA inspections and > > >> >> > it's > > >> >> > naming conventions rules. > > >> >> > IDEA inspections are under the project's git already. > > >> >> > > > >> >> > [1] > > >> >> > https://www.jetbrains.org/intellij/sdk/docs/basics/architectural_overview/virtual_file.html > > >> >> > On Fri, Nov 2, 2018 at 1:47 PM Yakov Zhdanov < > yzhda...@apache.org> > > >> >> wrote: > > >> >> > > > > >> >> > > No, I meant under Ignite's git so any change to resource file > > >> >> > > arrives > > >> >> with > > >> >> > > project workspace updates and gets automatically picked up by > > >> >> > > plugin. > > >> >> > > > > >> >> > > Makes sense? > > >> >> > > > > >> >> > > --Yakov > > >> >> > > > >> >> > > > >> >> > > > >> >> > -- > > >> >> > Best Regards, Vyacheslav D. > > >> >> > > >> >> > > >> >> > > >> >> -- > > >> >> Best Regards, Vyacheslav D. > > >> >> > > >> > > > >> > > >> > > >> -- > > >> Best regards, > > >> Ivan Pavlukhin > > > > > > > > > > > > -- > > > Best Regards, Vyacheslav D. > > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > > > -- > Best regards, > Ivan Pavlukhin >
