Igor,
I fixed my files.
Dmitry
On 10/13/18 12:14 AM, Igor Sapego wrote:
Dmitry,
I've run the tests and it appears that there are a lot of files without
Apache
licenses in Python client: [1] (See Unapproved licenses list).
Can you either add headers or exclude file from the check, if you can not
add one? I.e. to this list: [2]
[1] -
https://ci.ignite.apache.org/repository/download/IgniteTests24Java8_LicensesHeaders/2069024:id/rat.zip%21/target/rat.txt
[2] - https://github.com/apache/ignite/blob/master/parent/pom.xml#L817
Best Regards,
Igor
On Thu, Oct 11, 2018 at 1:13 PM Igor Sapego <isap...@apache.org> wrote:
Ok, I've filed a ticket [1] for the performance investigation and targeted
it to 2.8. Feel free to assign it to yourself.
I'm going to merge the ticket to master and ignite-2.7 branches by the
end of the week, if no one have any objections.
[1] - https://issues.apache.org/jira/browse/IGNITE-9850
Best Regards,
Igor
On Thu, Oct 11, 2018 at 12:18 PM Dmitry Melnichuk <
dmitry.melnic...@nobitlost.com> wrote:
Stepan,
Thank you for answering my question and for the updated results.
I have ran the profiler (cProfile) against the benchmark code you
provided and have not found any particular bottleneck. One cycle took me
434 μs, which is the same order of magnitude as your result.
I will need more time to analyze the performance of my client and find a
way to improve it. But is it a real stopper/blocker for the client
itself? If there are no other issues, may we merge and release the
client? Plus submit a jira-improvement to further investigate the
performance of the Python platform.
Dmitry
On 10/11/18 4:19 PM, Степан Пильщиков wrote:
Dmitry,
pip install -e from latest sources
On Thu, 11 Oct 2018, 06:37 Dmitry Melnichuk, <
dmitry.melnic...@nobitlost.com>
wrote:
Stepan!
Please tell me one thing about how you created the environment for your
benchmarks, namely: how did you install the Python client. Did you just
do `pip install pyignite`, or did you pull my working branch from the
downstream repository and did `pip install -e
ignite/modules/platforms/python`?
I highly recommend the latter, because PyPI version do not yet include
the latest improvements I did thanks to Dmitriy “qvad” Sherstobitov.
These improvements can have a noticeable positive effect on speed.
Dmitry
On 10/10/18 11:06 PM, Степан Пильщиков wrote:
Dmitry,
Thanks for review
Agree with all suggestions.
Made and run new benches without any redundant operations (prints,
time
calculation), only with "put" in "while true" cycle (almost)
Case description, environment, results and code in ticket
https://issues.apache.org/jira/browse/IGNITE-9824 (last comment)
Please review new metrics
Because picture is not changed so much, python still have performance
issues
