SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643151
########## File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js ########## @@ -171,9 +170,29 @@ function showChainCurrentStatusData(server, settings) { if (settings.isJiraAvailable()) { res += "<button onclick='commentJira(\"" + server.serverId + "\", \"IgniteTests24Java8_RunAll\", \"" - + server.branchName + "\")'>Comment JIRA</button>"; + + server.branchName + "\")'>Comment JIRA</button> "; } + var blockersList = ""; + + for (var i = 0; i < server.suites.length; i++) { + var suite = server.suites[i]; + + suite = suiteWithCriticalFailuresOnly(suite); + + if (suite != null) { + if (blockersList.length !== 0) + blockersList += ","; + + blockersList += suite.suiteId; + } + } + + res += "<button onclick='triggerBuilds(\"" + server.serverId + "\", \"" + blockersList + "\", \"" + server.branchName + "\", false, false)'> Re-run possible blockers</button> "; + + res += "<button onclick='triggerBuilds(\"" + server.serverId + "\", \"" + blockersList + "\", \"" + server.branchName + "\", false, true)'> Re-run possible blockers & Comment JIRA</button>"; Review comment: Too long line. Also, add `<br>` tag and move this under `settings.isJiraAvailable()` check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services