SomeFire commented on a change in pull request #19: DI refactoring
URL: https://github.com/apache/ignite-teamcity-bot/pull/19#discussion_r220537287
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/ObserverTask.java
##########
@@ -17,43 +17,82 @@
package org.apache.ignite.ci.observer;
+import java.util.HashSet;
import java.util.Queue;
+import java.util.Set;
import java.util.TimerTask;
import java.util.concurrent.ConcurrentLinkedQueue;
+import javax.inject.Inject;
import org.apache.ignite.ci.IAnalyticsEnabledTeamcity;
-import org.apache.ignite.ci.ITcHelper;
+import org.apache.ignite.ci.ITcServerProvider;
+import org.apache.ignite.ci.di.AutoProfiling;
+import org.apache.ignite.ci.di.MonitoredTask;
+import org.apache.ignite.ci.jira.IJiraIntegration;
import org.apache.ignite.ci.tcmodel.result.Build;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Checks observed builds for finished status and comments JIRA ticket.
*/
public class ObserverTask extends TimerTask {
+ /** Logger. */
+ private static final Logger logger =
LoggerFactory.getLogger(ObserverTask.class);
+
+ /** Helper. */
+ @Inject private ITcServerProvider srvProvider;
+
/** Helper. */
- private final ITcHelper helper;
+ @Inject private IJiraIntegration jiraIntegration;
/** Builds. */
final Queue<BuildInfo> builds;
/**
- * @param helper Helper.
*/
- ObserverTask(ITcHelper helper) {
- this.helper = helper;
+ ObserverTask() {
builds = new ConcurrentLinkedQueue<>();
}
/** {@inheritDoc} */
@Override public void run() {
+ try {
Review comment:
May be add `while(true)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
