SomeFire closed pull request #7: IGNITE-9542: new failure check fix
URL: https://github.com/apache/ignite-teamcity-bot/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
index 5652414..2b390f7 100644
--- a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
+++ b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
@@ -457,7 +457,9 @@ function showSuiteData(suite, settings) {
* @returns {boolean} True - if test is new. False - otherwise.
*/
function isNewFailedTest(testFailure) {
- return Number.parseFloat(testFailure.failureRate) < 4.0 ||
testFailure.flakyComments == null;
+ var recent = testFailure.histBaseBranch.recent;
+
+ return recent != null && Number.parseFloat(recent.failureRate) < 4.0 ||
testFailure.flakyComments == null;
}
function failureRateToColor(failureRate) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
