akalash commented on a change in pull request #3: IGNITE-9333 Add statistics
page
URL: https://github.com/apache/ignite-teamcity-bot/pull/3#discussion_r216378674
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
##########
@@ -261,7 +263,7 @@ private IgnitePersistentTeamcity(Ignite ignite,
IgniteTeamcityHelper teamcity) {
try {
apply = loadWithMerge.apply(key, persistedBuilds != null ?
persistedBuilds.getData() : null);
- final Expirable<V> newVal = new
Expirable<>(System.currentTimeMillis(), cnt, apply);
+ final Expirable<V> newVal = new
Expirable<>(System.currentTimeMillis(), cnt.get(), apply);
Review comment:
AtomicLong looks too difficult to understanding. I think will be better if
we will change V to List<V> and will calculate size of it right here. We can do
it because we know that V is always list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
