Maybe let's keep the functionality the way it is, since it doesn't interfere with the IEP?
But I think, it's worth mentioning as a warning in log, that a service is deployed on a client node. Denis вт, 24 июл. 2018 г. в 12:44, Vyacheslav Daradur <daradu...@gmail.com>: > No, it's doesn't complicate implementation on the current stage. > > But we will have to change assignment function to forbid client nodes > even if configuration's node filter resolves them it can be not > transparent for the end user. > > I think the only use case to have such behavior is: hosting of not > collocated services on data free nodes with access to IgniteCaches on > remote nodes in the same cluster. > > > > > On Tue, Jul 24, 2018 at 12:10 PM Denis Mekhanikov <dmekhani...@gmail.com> > wrote: > > > > I don't think, that client nodes, that host services make much sense. > > May we forbid it? Does anybody know, when it may be useful? > > > > Vyacheslav, does it complicate the implementation somehow? > > > > Denis > > > > вт, 24 июл. 2018 г. в 11:57, Vyacheslav Daradur <daradu...@gmail.com>: > > > > > Hi, Igniters! > > > > > > I am close to completing the main tasks and I'm going to request a > > > review in a couple weeks. > > > > > > I have a question about the new design: > > > > > > The current implementation of Service Grid doesn't' take into account > > > Ignition#client(true). > > > It means that *clients* nodes are able to host services. There are > > > some tests that expect such behavior. > > > > > > Services assignments are managed by a predicate only > > > (ServiceConfiguration#setNodeFilter(IgnitePredicate<ClusterNode>). > > > > > > Should deployment on clients nodes be forbidden or we shouldn't mix > > > concepts for IgniteCache with Service Grid? > > > > > > > > > On Wed, Jun 20, 2018 at 1:46 AM Dmitriy Setrakyan < > dsetrak...@apache.org> > > > wrote: > > > > > > > > On Tue, Jun 19, 2018 at 1:50 PM, Vyacheslav Daradur < > daradu...@gmail.com > > > > > > > > wrote: > > > > > > > > > Hi Dmitriy, > > > > > > > > > > Yes, the task [1] is planned to be implemented once the main tasks > > > > > will be completed. > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-8367 > > > > > > > > > > > > Awesome! This is a huge addition to the project. > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jun 19, 2018 at 10:06 PM Dmitriy Setrakyan > > > > > <dsetrak...@apache.org> wrote: > > > > > > > > > > > > Hi Vyacheslav, > > > > > > > > > > > > How about service redeployment in case if user wants to update > the > > > code? > > > > > Is > > > > > > this planned? > > > > > > > > > > > > D. > > > > > > > > > > > > > > > > > > > > > > > -- > > > Best Regards, Vyacheslav D. > > > > > > > -- > Best Regards, Vyacheslav D. >
