Guys, I reviewed changes in IGNITE-8740, but I'm not sure the fix is correct. I left a more detailed comment in the ticket. Hopefully, Mair will be able to respond shortly and clarify.
-Val On Fri, Jun 22, 2018 at 10:58 AM Denis Magda <dma...@apache.org> wrote: > Dmitriy, > > No, that's an honor for us to see you in this role ;) Both Andrey Gura, > Anton Vinogradov are our release-management veterans. Please feel free to > contact them directly. > > Could you take over this ticket review and include it in the release: > https://issues.apache.org/jira/browse/IGNITE-8740 > > It's not good that we have spring integration broken in some places in > several releases. I would treat is as a usability blocker and regression. > > -- > Denis > > > > On Fri, Jun 22, 2018 at 3:06 AM Dmitry Pavlov <dpavlov....@gmail.com> > wrote: > > > Hi Alexey, > > > > Sure, it will be honor for me. > > > > In the same time I relatevely new in this area, so I would highly > > appreciate any assistance of experienced community members to make this > > happen. > > > > Sincerely, > > > > пт, 22 июн. 2018 г. в 12:18, Alexey Goncharuk < > alexey.goncha...@gmail.com > > >: > > > > > Denis, > > > > > > Currently, I am not aware of anybody who can immediately review and > > > sign-off the suggested patch. The original scope of tickets have been > > > resolved, so I suggest to move on with what we have now. > > > > > > I will not be able to continue with the release process until Thursday > > > next week. > > > > > > Dmitriy Pavlov, do you mind taking over and finishing the release? > > > > > > чт, 21 июн. 2018 г. в 23:02, Denis Magda <dma...@apache.org>: > > > > > >> Folks, > > >> > > >> This release no longer reminds an emergency one :) Are we done with > the > > >> scope, who is a release manager? > > >> > > >> From my side, I'd like us to review and add the fix for broken Spring > > >> integration which is a significant regression: > > >> https://issues.apache.org/jira/browse/IGNITE-8740 > > >> > > >> -- > > >> Denis > > >> > > >> On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk < > > >> alexey.goncha...@gmail.com> > > >> wrote: > > >> > > >> > Hi Petr, > > >> > > > >> > Who will be able to make the review for the suggested patch? I would > > >> like > > >> > to freeze the branch and start preparing the release. > > >> > > > >> > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <mr.wei...@gmail.com>: > > >> > > > >> > > Igniters, > > >> > > > > >> > > > > >> > > I’d like to stage for 2.6 release also this issue [1]. > Corresponding > > >> PR > > >> > > [2] is ready for review and merge. > > >> > > This is not related to code additional configuration file for > > enabling > > >> > > support of Windows 10 WSL Environment. > > >> > > > > >> > > > > >> > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 > > >> > > [2] https://github.com/apache/ignite/pull/4194 > > >> > > > > >> > > > > >> > > > > >> > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov < > akuznet...@apache.org > > > > > >> > > wrote: > > >> > > > > > >> > > > Hi, > > >> > > > > > >> > > > Fix for IGNITE-8722 ( > > >> https://issues.apache.org/jira/browse/IGNITE-8722 > > >> > ) > > >> > > is > > >> > > > ready. > > >> > > > > > >> > > > Diff > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > > >> > > > > > >> > > > TC looks good for me. > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > > >> > > > > > >> > > > I'm ready to merge to master and 2.6 branches. > > >> > > > Please approve. > > >> > > > > > >> > > > -- > > >> > > > Alexey Kuznetsov > > >> > > > > >> > > > > >> > > > >> > > > > > >
