Alexey, +1.
I personally also follow this style. On Thu, May 3, 2018 at 12:45 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Actually, I've been following the suggested code style for quite a while. > I'm ok to add this to coding guidelines, however, I think we should allow > the old style when the method signature (without throws clause) fits the > line. > > Thoughts? > > 2018-05-03 12:09 GMT+03:00 Dmitry Pavlov <dpavlov....@gmail.com>: > > > Hi Dmitriy, > > > > I like your proposal, so +1 from me. > > > > I think it would make code more readable and easy to understand. > > > > Sincerely, > > Dmitriy Pavlov > > > > чт, 3 мая 2018 г. в 11:31, Dmitriy Govorukhin < > > dmitriy.govoruk...@gmail.com > > >: > > > > > Hi folks, > > > > > > I read > > > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines, > > > but did not find anything about code style for method arguments. > > > > > > In many places in the code, I see different code style, this creates > > > difficulties for reading. > > > > > > It seems to me an example below is rather difficult to perceive. > > > > > > ```java > > > public void foo(Object obj1, > > > Object obj2, Object obj3,... ,Object objN){ > > > .... > > > } > > > ``` > > > An example GridCacheProcessor.addCacheOnJoin(...) > > > > > > ```java > > > private void addCacheOnJoin(CacheConfiguration<?, ?> cfg, boolean > > sql, > > > Map<String, CacheInfo> caches, > > > Map<String, CacheInfo> templates) > > > ``` > > > I suggest two options for writing arguments. > > > > > > If arguments are placed in a line before the page delimiter. > > > > > > ```java > > > public void foo(Object obj1, Object obj2, Object obj3 , ... , Object > > objN){ > > > .... > > > } > > > ``` > > > If the arguments are not placed in the line before the page delimiter. > > > > > > ```java > > > public void foo( > > > Object obj1, > > > Object obj2, > > > Object obj3, > > > ... , > > > Object objN > > > ){ > > > .... > > > } > > > ``` > > > In my personal experience, the last example is much easier to merge if > > > method arguments were changed. > > > > > >
