Excellend picture. I remember about this change. If Denis M. would be able to look througt the changes faster than me, I can merge without detailed review.
пт, 6 апр. 2018 г. в 16:15, Роман Меерсон <homich1...@gmail.com>: > OK > > [image: 1486924635147168240.jpg] > > > пт, 6 апр. 2018 г. в 17:08, Igor Sapego <isap...@apache.org>: > >> Hi, >> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago, >> so I guess, the merge is going to happen in 1-2 days or so. >> >> >> Best Regards, >> Igor >> >> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон <homich1...@gmail.com> >> wrote: >> >> > Hi all! >> > >> > As i see everything is awesome and there is no objections, so when my PR >> > would be merged? >> > >> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <slava.kopti...@gmail.com >> >: >> > >> > > Thank you, Roman! >> > > >> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон <homich1...@gmail.com>: >> > > >> > > > Hi Slava, >> > > > >> > > > Fixed >> > > > >> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин < >> > slava.kopti...@gmail.com >> > > >: >> > > > >> > > > > Hi Roman, >> > > > > >> > > > > please take into account my comment IgniteQueryGenerator.java >> > > > > < >> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541? >> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94&filePath=/ >> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/ >> > > > springdata/repository/query/IgniteQueryGenerator.java >> > > > > > >> > > > > >> > > > > Best regards, >> > > > > Slava. >> > > > > >> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <homich1...@gmail.com>: >> > > > > >> > > > > > Ok, so waiting for accept and commit >> > > > > > >> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin < >> > > > kukushkinale...@gmail.com >> > > > > >: >> > > > > > >> > > > > > > Roman, >> > > > > > > >> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely commit >> your >> > > code) >> > > > > > > attention to include the new test suite to TeamCity >> > configuration. >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> >
