Awesome! Dmitriy, please confirm donation and apply the patch.
BTW, we can relocate plugin to apache repo like we did for release scripts [1]. [1] https://github.com/apache/ignite-release 2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur <daradu...@gmail.com>: > Hi, Igniters! > > I got into the task [1] in agreement with Dmitry. > > I’ve prepared the PR [2] with following changes: > - added Apache 2.0 license to the header of each file > - replaced prefix ‘Grid’ by ‘Ignite’ in class names > - added README.md with a simple description > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub > releases tab and completely new versioning isn't preferable IMO > > Also, I’ve built new artifact and tested it, it works well. > > Am I understood the task correct? > If not, please share your notes I will fix them shortly. > > As far as I understand someone of GridGain employee should confirm the > plugin's code's donation. It’d be great to confirm that by corporate > email. > > > [1] https://issues.apache.org/jira/browse/IGNITE-5698 > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1 > > > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dpavlov....@gmail.com> > wrote: > > Hi Dmitriy, Denis, > > > > Thank you for your effort to find out solution. > > It sound good for me, I have assigned IGNITE-5698 to myself. > > > > Best Regards, > > Dmitriy Pavlov > > > > > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dma...@apache.org>: > > > >> Dmitriy P., > >> > >> Does it sound good to you? If yes, please make sure the plugin is > >> available via a public GitHub repo and refer to it from the doc. > >> > >> — > >> Denis > >> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <dsetrak...@apache.org> > >> wrote: > >> > > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dma...@apache.org> > wrote: > >> > > >> >> Ok, what if we make sure the plugin is available on GitHub (not > Ignite) > >> >> and give a link to it on the documentation page? This seems to be the > >> >> easiest way to handle the topic. > >> > > >> > > >> > I think this will work. > >> > >> > > > > -- > Best Regards, Vyacheslav D. >
