Dmitry, Nickolay accepted PR changes at Upsource [1].
Latest ci.build [2] looks good in comparison with master [3]. Following tests passed locally: CacheAffinityCallSelfTest.testAffinityCallFromClientRestartNode CacheAffinityCallSelfTest.testAffinityCallRestartNode IgniteOptimisticTxSuspendResumeMultiServerTest.testTxTimeoutOnSuspend IgniteSqlSplitterSelfTest.testReplicatedTablesUsingPartitionedCacheSegmentedClient [1] https://reviews.ignite.apache.org/ignite/review/IGNT-CR-509 [2] https://ci.ignite.apache.org/viewLog.html?buildId=1134466 [3] https://ci.ignite.apache.org/viewLog.html?buildId=1134372 On Mon, Mar 5, 2018 at 7:16 PM, Vyacheslav Daradur <daradu...@gmail.com> wrote: > Dmitry, I saw them, but it looks like just randomness. > > I've checked it locally several times. > They failed only in one TeamCity's build of four. > > Started build once again to be sure. > > On Mon, Mar 5, 2018 at 6:59 PM, Dmitry Pavlov <dpavlov....@gmail.com> wrote: >> I can see Nikolay Izhikov as reviewer in Upsource. >> >> Nikolay, would you run review first? >> >> I've found several suspicious tests : Test fail rate is less than 1%, it is >> probably new failure >> IgniteCacheTestSuite2: >> GridCachePartitionedTxSingleThreadedSelfTest.testOptimisticReadCommittedRollback >> (fail rate 0,0%) >> IgniteCacheTestSuite2: >> GridCachePartitionedTxSingleThreadedSelfTest.testOptimisticRepeatableReadRollback >> (fail rate 0,0%) >> IgniteCacheTestSuite2: >> GridCachePartitionedTxSingleThreadedSelfTest.testPessimisticReadCommittedCommit >> (fail rate 0,0%) >> IgniteCacheTestSuite2: >> GridCachePartitionedTxSingleThreadedSelfTest.testPessimisticReadCommittedRollback >> (fail rate 0,0%) >> IgniteCacheTestSuite2: >> GridCachePartitionedTxSingleThreadedSelfTest.testPessimisticSerializableCommit >> (fail rate 0,0%) >> >> Vyacheslav, could you please check if these failures are related to the new >> changes? >> >> >> пн, 5 мар. 2018 г. в 18:50, Vyacheslav Daradur <daradu...@gmail.com>: >> >>> I've done some test-builds iteration on the weekends. >>> >>> Tests [1] look well. >>> >>> Does anyone have time to do the final review [2][3] and merge it? >>> >>> >>> [1] https://ci.ignite.apache.org/viewLog.html?buildId=1125676 >>> [2] https://github.com/apache/ignite/pull/3578 >>> [3] https://reviews.ignite.apache.org/ignite/review/IGNT-CR-509 >>> >>> >>> On Fri, Mar 2, 2018 at 10:17 PM, Vyacheslav Daradur <daradu...@gmail.com> >>> wrote: >>> > Hi, Igniters! >>> > >>> > This task [1] is about 'get' requests distribution between primary and >>> > backup nodes in the replicated cache if 'readFromBackup' flag is >>> > enabled. >>> > >>> > I've prepared a solution [2] suggested by Alexei Scherbakov in Jira >>> > comments. It passed prereviews by Alexei and Nikolay Izhikov. >>> > >>> > TeamCity tests look similar with the master branch. >>> > >>> > Could someone of core module maintainers do the final review [2][3]? >>> > >>> > >>> > [1] https://issues.apache.org/jira/browse/IGNITE-5357 >>> > [2] https://github.com/apache/ignite/pull/3578 >>> > [3] https://reviews.ignite.apache.org/ignite/review/IGNT-CR-509 >>> > >>> > -- >>> > Best Regards, Vyacheslav D. >>> >>> >>> >>> -- >>> Best Regards, Vyacheslav D. >>> > > > > -- > Best Regards, Vyacheslav D. -- Best Regards, Vyacheslav D.
