Hi Sunny, Thanks for the notification. Just found this PR. Will review it a bit later.
Igor On Tue, Jan 16, 2018 at 7:15 PM, Sunny Chan, CLSA <sunny.c...@clsa.com> wrote: > Hi Igor, > > Any luck with the review and merge of the patch? > > Thanks > > -----Original Message----- > From: Denis Magda [mailto:dma...@apache.org] > Sent: Friday, January 05, 2018 4:29 AM > To: dev@ignite.apache.org; Igor Rudyak > Cc: Nikolai Tikhonov > Subject: Re: IGNITE-6252 patch > > Hello, > > I hope Igor R. will review the changes as soon as prolonged holidays are > over. > > — > Denis > > > On Jan 2, 2018, at 5:24 PM, Sunny Chan, CLSA <sunny.c...@clsa.com> > wrote: > > > > Hello, > > > > I have replied to the comment in November and I am okay with your > updated patch – what do I need to do to move this forward? > > > > From: Nikolai Tikhonov [mailto:ntikho...@apache.org] > > Sent: Tuesday, October 31, 2017 11:50 PM > > To: dev@ignite.apache.org; Sunny Chan, CLSA > > Subject: Re: IGNITE-6252 patch > > > > Hello, > > > > Thank you for your contribution! I've reviewed your changes and left > comment to ticket. Could you look jira https://issues.apache.org/ > jira/browse/IGNITE-6252? > > > > On Mon, Oct 30, 2017 at 10:57 AM, Sunny Chan, CLSA <sunny.c...@clsa.com > <mailto:sunny.c...@clsa.com>> wrote: > > Hello, > > > > During our testing we have found an issue and I have raised a JIRA > ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also > provided a patch that would fix the issue. Could someone take a look and > see whether the patch is acceptable? > > > > Thanks. > > The content of this communication is intended for the recipient and is > subject to CLSA Legal and Regulatory Notices. > > These can be viewed at https://www.clsa.com/disclaimer.html or sent to > you upon request. > > CLSA is ISO14001 certified and committed to reducing environmental > impact. > > > > The content of this communication is intended for the recipient and is > subject to CLSA Legal and Regulatory Notices. > > These can be viewed at https://www.clsa.com/disclaimer.html or sent to > you upon request. > > CLSA is ISO14001 certified and committed to reducing environmental > impact. > > > The content of this communication is intended for the recipient and is > subject to CLSA Legal and Regulatory Notices. > These can be viewed at https://www.clsa.com/disclaimer.html or sent to > you upon request. > Please consider before printing. CLSA is ISO14001 certified and committed > to reducing its impact on the environment. >