Thanks, Petr. I heard of some activity related to performance consequences of ReentrantLocks in IGNITE-6736 fix. So, I'd like to get a reviewer feedback first.
Andrey G., Vladimir O., is it possible to merge the fix to master? 2018-01-10 9:56 GMT+03:00 Petr Ivanov <mr.wei...@gmail.com>: > Andrey — double checked your solution and it works now. Guess there was > some merge error first time. > Sorry for misleading. > > So, there is working solution for Java 9 build and I’d like to save this > configuration in ignite-6730 (making IGNITE-7144 and IGNITE-6736 to become > subtasks in the process). > What do you think? > > > > On 9 Jan 2018, at 20:49, Andrey Kuznetsov <stku...@gmail.com> wrote: > > > > Hi Petr! > > > > Could you please clarify what is wrong with fix proposed in IGNITE-6736, > > and what is supposed to be a replacement for monitorEnter/monitorExit > now? > > > > 2018-01-09 19:08 GMT+03:00 Petr Ivanov <mr.wei...@gmail.com>: > > > >> Hi all. > >> > >> > >> After some thorough research and with help of fellow igniters, I’ve > >> managed to prepare more or less stable Java 9 build configuration of > Apache > >> Ignite. > >> > >> Here are changes to make it work: > >> - Java 8 profiles and build process revision, made in IGNITE-7203; > >> - Java 9 maven profile prepared in IGNITE-7144 (will be moved to > >> IGNITE-6730 as subtask); > >> - specific maven-compiler-plugin configuration with JVM args for Java 9 > >> profile (as was proposed by Vladimir Ozerov); > >> - maven-bundle-plugin version is updated to 3.5.0; > >> - maven-compiler-plugin version synchronised to 3.7.0 (in Cassandra > >> modules); > >> - scala version updated to 2.12.4; > >> - disabled scalar-2.10, spark-2.10 and visor-console-2.10 modules (due > to > >> dependency in scala 2.10 which is unsupported by Java 9); > >> - sun.misc.JavaNioAccess import changed to jdk.internal.misc. > JavaNioAccess > >> in GridUnsafe.java and PageMemoryImpl.java; > >> - sun.misc.SharedSecrets import changed to jdk.internal.misc. > SharedSecrets > >> in GridUnsafe.java and PageMemoryImpl.java; > >> - methods monitorEnter and monitorExit bodies commented out (fix from > >> IGNITE-6736 did not work). > >> > >> I’d like to put these changes into ignite-6730 to have working compiling > >> under Java 9 branch — so that we can continue work on improving Apache > >> Ignite’s Java 9 support. > > > > > > > > > > -- > > Best regards, > > Andrey Kuznetsov. > > -- Best regards, Andrey Kuznetsov.
